lp://staging/~zsombi/ubuntu-ui-toolkit/app-theming-to-staging

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/ubuntu-ui-toolkit/staging at revision 1364

PS Jenkins bot: Approve (continuous-integration) on 2014-12-05

Cris Dywan: Approve on 2014-12-04

Diff: 518 lines (+368/-20)

16 files modified

examples/customtheme/customtheme.apparmor (+8/-0)
examples/customtheme/customtheme.desktop (+8/-0)
examples/customtheme/customtheme.qmlproject (+59/-0)
examples/customtheme/main.qml (+103/-0)
examples/customtheme/manifest.json (+15/-0)
examples/customtheme/theme/Palette.qml (+24/-0)
examples/customtheme/theme/parent_theme (+1/-0)
modules/Ubuntu/Components/MainView.qml (+16/-0)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+0/-17)
modules/Ubuntu/Components/plugin/uctheme.cpp (+3/-1)
tests/unit_x11/tst_components/tst_theming.qml (+60/-0)
tests/unit_x11/tst_theme_engine/AppTheme/Palette.qml (+24/-0)
tests/unit_x11/tst_theme_engine/AppTheme/parent_theme (+1/-0)
tests/unit_x11/tst_theme_engine/TestApp.qml (+29/-0)
tests/unit_x11/tst_theme_engine/tst_theme_engine.pro (+3/-1)
tests/unit_x11/tst_theme_engine/tst_theme_enginetest.cpp (+14/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1213043: Binding loop detected when changing backgroundColor of MainView dynamically	High	Fix Released
Bug #1277647: Changing theme from Ambiance to SuruDark or SuruGradient in MainView's completion causes binding loops.	Undecided	Fix Released
Bug #1330510: Valgrind warning when theme is changed from MainViewStyle.qml	High	Fix Released
Bug #1356779: [SDK] MainView.backgroundColor is not usable any more	High	Fix Released
Bug #1389792: theme not found when using a user-defined theme	High	Fix Released

Link a bug report

Related blueprints

1365. By Zsombor Egri on 2014-12-04

missing unit test added

1364. By Zsombor Egri on 2014-12-04

App theming and other theming related fixes

1363. By Cris Dywan on 2014-12-03

Do the default theme check properly: for non-debug and without build errors.

Approved by PS Jenkins bot, Zsombor Egri.

1362. By Daniel d'Andrada on 2014-12-03

This is needed by unity8 for the "shell rotation" feature (ie shell does all the rotation work instead of apps rotating themselves). unity8's dialogs (like the power dialog when you long press the power button) should follow its parent item rotation and size, as one would expect, and not be sneakily reparented to the scene root item, in which case the shell UI would be rotated but its dialog would not.

PPA with shell rotation:
https://launchpad.net/~unity-team/+archive/ubuntu/demo-stuff

And this is how unity8 is using Dialogs:
http://bazaar.launchpad.net/~unity-team/unity8/shellRotation/view/head:/qml/Components/Dialogs.qml

Related bug: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1394511. Fixes: https://bugs.launchpad.net/bugs/1394511.

Approved by PS Jenkins bot, Zsombor Egri.

1361. By Cris Dywan on 2014-12-03

Don't activate the control in ListItem.Standard implicitly. Fixes: https://bugs.launchpad.net/bugs/1372563.

Approved by PS Jenkins bot, Zsombor Egri.

1360. By Zsombor Egri on 2014-12-03

ServiceProperties component to Ubuntu.Components 1.1. Fixes: https://bugs.launchpad.net/bugs/1391877.

Approved by Christian Dywan, PS Jenkins bot.

1359. By Zsombor Egri on 2014-12-03

New ListItem component base. Support for leading/trailing actions. Exported in Ubuntu.Components 1.2 UNSTABLE release. Fixes: https://bugs.launchpad.net/bugs/1097728, https://bugs.launchpad.net/bugs/1372592, https://bugs.launchpad.net/bugs/1383870.

Approved by PS Jenkins bot, Tim Peeters.

1358. By Cris Dywan on 2014-12-03

Add sortCaseSensitivity to the SortFilterModel example. Fixes: https://bugs.launchpad.net/bugs/1391034.

Approved by PS Jenkins bot, Tim Peeters.

1357. By Cris Dywan on 2014-12-03

Change offending links into bold font. Fixes: https://bugs.launchpad.net/bugs/1395011.

Approved by PS Jenkins bot, Timo Jyrinki.

1356. By Zoltan Balogh on 2014-12-03

loicm - Made the UCAlarmPrivate destructor private.