Merge lp://staging/~zsombi/ubuntu-ui-toolkit/60-action-value-type into lp://staging/~zsombi/ubuntu-ui-toolkit/listitem-master

19 actionsRow.selectedAction.trigger(actionsRow.listItemIndex >= 0 ? actionsRow.listItemIndex : null);
20 actionsRow.selectedAction = null;

should this be guarded by if (parameterType == Integer) ?

16 + if (actionsRow.selectedAction.parameterType === Action.None) {
17 + actionsRow.selectedAction.parameterType = Action.Integer;
18 + }

Is there an easy way to check this only once when the ListItemActions is created for all of its Actions, instead of every time an action is triggered?

^or perhaps it makes sense to change the default to Integer, or to auto-detect the type in ucaction.cpp?

67 + * However this will only work if the \l {Action::parameterType}{parameterType}
68 + * will be set to Action.Integer or not set at all, in which case the ListItem
69 + * will set the type to Action.Integer.

Alternatively, we can simply change the doc to ", in which case the ListItem will change the type from Action.None to Action.Integer when it is triggered." to be more explicit about what will happen.

Do we have a need to somehow support other parameter types here? (I don't know how). If not, let's not pass the index when the type is different (add the if-statement of my first comment), and add a sentence to the doc: "If the parameterType is neither Action.Integer or the default Action.None, no value will be passed when triggering the action."

> 19
> actionsRow.selectedAction.trigger(actionsRow.listItemIndex >= 0 ?
> actionsRow.listItemIndex : null);
> 20 actionsRow.selectedAction = null;
>
> should this be guarded by if (parameterType == Integer) ?

Action.trigger() handles that.

> 16 + if (actionsRow.selectedAction.parameterType ===
> Action.None) {
> 17 + actionsRow.selectedAction.parameterType =
> Action.Integer;
> 18 + }
>
> Is there an easy way to check this only once when the ListItemActions is
> created for all of its Actions, instead of every time an action is triggered?

We can do that in C++, yes. Revno 1293 is the one having it.

> 67 + * However this will only work if the \l
> {Action::parameterType}{parameterType}
> 68 + * will be set to Action.Integer or not set at all, in which case the
> ListItem
> 69 + * will set the type to Action.Integer.
>
>
> Alternatively, we can simply change the doc to ", in which case the ListItem
> will change the type from Action.None to Action.Integer when it is triggered."
> to be more explicit about what will happen.

Happened. revno 1295.

>
> Do we have a need to somehow support other parameter types here? (I don't know
> how). If not, let's not pass the index when the type is different (add the if-
> statement of my first comment), and add a sentence to the doc: "If the
> parameterType is neither Action.Integer or the default Action.None, no value
> will be passed when triggering the action."

We cannot really handle other parameters tbh... I mean only thing we know is the index of the ListItem. Not more. And Action.trigger() will pass undefined to the signal if the functoins' parameter type differs from the one in parameterType.

thanks, it works as expected now.