Merge lp://staging/~zsombi/ubuntu-ui-toolkit/45-selected-option-rebinds into lp://staging/~zsombi/ubuntu-ui-toolkit/listitem-master
Proposed by
Zsombor Egri
| Status: | Merged |
|---|---|
| Approved by: | Tim Peeters |
| Approved revision: | 1288 |
| Merged at revision: | 1274 |
| Proposed branch: | lp://staging/~zsombi/ubuntu-ui-toolkit/45-selected-option-rebinds |
| Merge into: | lp://staging/~zsombi/ubuntu-ui-toolkit/listitem-master |
| Prerequisite: | lp://staging/~zsombi/ubuntu-ui-toolkit/40-visualize-options |
| Diff against target: |
198 lines (+63/-17) 3 files modified
modules/Ubuntu/Components/Themes/Ambiance/ListItemPanel.qml (+22/-6) modules/Ubuntu/Components/plugin/uclistitem_p.h (+1/-3) tests/unit_x11/tst_components/tst_listitem.qml (+40/-8) |
| To merge this branch: | bzr merge lp://staging/~zsombi/ubuntu-ui-toolkit/45-selected-option-rebinds |
| Related bugs: | |
| Related blueprints: |
SDK: Design a new ListItem and layouts
(Undefined)
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tim Peeters | Approve | ||
|
Review via email:
|
|||
Commit message
Selected leading/trailing action rebinds contentItem.
To post a comment you must log in.
Revision history for this message
| Tim Peeters (tpeeters) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
for lp:~tpeeters/+junk/lists I am trying to print the index of the list item for which an action was triggered, by adding
onTriggered: print("Action "+value)
value returns undefined if I don't set the parameterType of the Action to be Integer.
Can/Should we set the parameterType automatically? Or at least document that we should set it here? We can at least check that the parameterType is Integer, but I'm not sure what to do if it is not.