Code review comment for lp://staging/~zsombi/ubuntu-ui-toolkit/40-visualize-options

Revision history for this message
Zsombor Egri (zsombi) wrote :

> I like to have some more flexibility in coloring the background of the panel.
> Currently the left one is always red, the right one white.

As discussed, we can add these properties to ListItemActions, but that will always be applied to these objects. The panel delegates are linked to ListItems, so in that sense these properties would rather be welcomed there than ListItemActions. We can discuss this later, and perhaps have it in a later MR.
>
> I would like to have the possibility to easily change these standard colors
> (left: green, right: yellow, or example). And maybe even have the possibility
> to change the background color per action in each of the panels. That last
> possibility is still a point of discussion.

Per action can be driven thru the ListItemActions.delegate (comes in MR# 50). Otherwise these color props must be added to action, which shouldn't be the case. OTOH, custom panel theme can be used any time for this.

« Back to merge proposal