Merge lp://staging/~zomux/twisted-buildbot-configuration/add-builder-twistedchecker into lp://staging/~exarkun/twisted-buildbot-configuration/trunk

The buildstep is pretty much a copy&paste from the documentation checker. The code should really be factored out into a common base class.

Probably both createSummary and getPreviousLog can be moved to the base class, and use a class attribute to specify which log file to grab.

Sorry for taking so long to get to this, it arrived when I had almost no review bandwidth.

I'll do the refactoring eventually, if somebody else doesn't get there first.

Can we deploy it before the refactoring happens? It would be great to have this functionality, and refactoring to reduce code duplication doesn't seem extremely high priority - certainly not a blocking issue. Is something else wrong with the branch?

> Can we deploy it before the refactoring happens? It would be great to have
> this functionality, and refactoring to reduce code duplication doesn't seem
> extremely high priority - certainly not a blocking issue. Is something else
> wrong with the branch?

As I'm not quite familiar with inside mechanism Of buildbot, not clear how to the refactoring should be done.

Huh ... If its just easy code rearrangement, I could try to do it.

ping

Hi,

Okay, I will review it these days, code refactoring..

On Fri, Nov 16, 2012 at 6:57 AM, Jean-Paul Calderone <
<email address hidden>> wrote:

> ping
> --
>
> https://code.launchpad.net/~zomux/twisted-buildbot-configuration/add-builder-twistedchecker/+merge/113883
> You are the owner of
> lp:~zomux/twisted-buildbot-configuration/add-builder-twistedchecker.
>

--
 *Raphael Shu , UACA 2012*

I've refactored the code here:
https://code.launchpad.net/~tom.prince/twisted-buildbot-configuration/twistedchecker
but it appears there isn't a default branch for twistedchecker, so lp:twistedchekcer doesn't work.

Hi,

Okay, I have set the default branch of lp:twistedchecker ( to
lp:~zomux/twistedchecker/trunk )

and I think It should work now.

On Sat, Nov 24, 2012 at 5:34 AM, Tom Prince <email address hidden> wrote:

> I've refactored the code here:
>
> https://code.launchpad.net/~tom.prince/twisted-buildbot-configuration/twistedchecker
> but it appears there isn't a default branch for twistedchecker, so
> lp:twistedchekcer doesn't work.
> --
>
> https://code.launchpad.net/~zomux/twisted-buildbot-configuration/add-builder-twistedchecker/+merge/113883
> You are the owner of
> lp:~zomux/twisted-buildbot-configuration/add-builder-twistedchecker.
>

--
 *Raphael Shu , UACA 2012*

https://buildbot.twistedmatrix.com/builders/twistedchecker/builds/2/steps/run-twistedchecker/logs/stdio

Err... I could not repeat this error on my machine,

Whats the version of pylint and pep8.py installled there?

On Sat, Nov 24, 2012 at 12:21 PM, Tom Prince <email address hidden>wrote:

>
> https://buildbot.twistedmatrix.com/builders/twistedchecker/builds/2/steps/run-twistedchecker/logs/stdio
> --
>
> https://code.launchpad.net/~zomux/twisted-buildbot-configuration/add-builder-twistedchecker/+merge/113883
> You are the owner of
> lp:~zomux/twisted-buildbot-configuration/add-builder-twistedchecker.
>

--
 *Raphael Shu , UACA 2012*

# pylint --version
pylint 0.25.1,
astng 0.21.1, common 0.55.0
Python 2.7.1+ (r271:86832, Apr 11 2011, 18:13:53)
[GCC 4.5.2]
# pep8 --version
1.2

Hi,

Thanks for this information .

The main reason causes the problem is the version of astng and pep8.py .

Could you upgrade logilab-astng to 0.24.1 and upgrade pep8.py to 1.3.3?

This could be done simply by these commands:
*# pip install logilab-astng --upgrade*
*# pip install pep8 --upgrade*
*
*
or I need to add support for these versions ... huh .. that would a lot of
work.

Thanks!

On Sun, Nov 25, 2012 at 2:23 AM, Tom Prince <email address hidden> wrote:

> # pylint --version
> pylint 0.25.1,
> astng 0.21.1, common 0.55.0
> Python 2.7.1+ (r271:86832, Apr 11 2011, 18:13:53)
> [GCC 4.5.2]
> # pep8 --version
> 1.2
>
> --
>
> https://code.launchpad.net/~zomux/twisted-buildbot-configuration/add-builder-twistedchecker/+merge/113883
> You are the owner of
> lp:~zomux/twisted-buildbot-configuration/add-builder-twistedchecker.
>

--
 *Raphael Shu , UACA 2012*

raphael shu <email address hidden> writes:

> Could you upgrade logilab-astng to 0.24.1 and upgrade pep8.py to 1.3.3?

What are the minimum currently supported versions?

I'm using system packages, so pip isn't an option.

The machine is ubuntu natty, so the included versions aren't sufficient,
but I've been grabbing packages from quantal. Is logilab-astng 0.23.1
sufficient?

Hi,

Thanks for replying.

logilab-astng 0.23.1 is okay.

also, the checker requires pep8.py version 1.0.1 or 1.3.3

pep8.py 1.2 seems a little strange and will cause error.

On Sun, Nov 25, 2012 at 10:52 AM, Tom Prince <email address hidden>wrote:

> raphael shu <email address hidden> writes:
>
> > Could you upgrade logilab-astng to 0.24.1 and upgrade pep8.py to 1.3.3?
>
> What are the minimum currently supported versions?
>
> I'm using system packages, so pip isn't an option.
>
> The machine is ubuntu natty, so the included versions aren't sufficient,
> but I've been grabbing packages from quantal. Is logilab-astng 0.23.1
> sufficient?
>
>
> --
>
> https://code.launchpad.net/~zomux/twisted-buildbot-configuration/add-builder-twistedchecker/+merge/113883
> You are the owner of
> lp:~zomux/twisted-buildbot-configuration/add-builder-twistedchecker.
>

--
 *Raphael Shu , UACA 2012*

https://buildbot.twistedmatrix.com/builders/twistedchecker/builds/5

This has been merged.

Hi,

I&#39;d like to add you to my professional network on LinkedIn.

- Raphael

Accept: http://www.linkedin.com/blink?simpleRedirect=0Uc3oUe3sUdP0Oej8Ndz4RczARfkh9rCZFt65QqnpKqipMjQtbgkRIijRVpkJApn9xq7cCt7dBtmtvpnhFtCVFfmJB9C5QoORBt6BSrCAJt7dBtmsJr6RBfmtKqmJzon9Q9ClQqnpKimtBkClOs3Rx9zwNbmBVqShVuj1FbmkSpmESczRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I8065275063_1&markAsRead=

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: http://www.linkedin.com/blink?simpleRedirect=e34JqnBHp7BVc6AJpjpBqzoOfmhFpipTmBZge7lBcTBGu6tae39Trzd7pCtgkloMjORGgkB4qSJ7djpVd5oJr6FxbmpKmj1fj5hvskZIkldilCtojCVkjTATsRoPrn1Glk51gk5gc4ZTuj9igCIJhB51fmhFrSMCt7dBtmtvpnhFtCVFfmJB9B4ScSh5hSxmhD9JhB51fmVBqSZkp6BJ9CVRr3RQ9zwNbmBVqShVuj1FbmkSpmESczRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&amp;msgID=I8065275063_1&amp;markAsRead= Learn why we included this at the following link: http://www.linkedin.com/blink?simpleRedirect=3wUdPgZp4BBr6dFt79x9DhPpnlDnSlQqnpKqjRHpipIsBlBoSBSsCljsClJrThPtmcZoioUciRFumJAunAMqiRBdClGdz8ZpjYOtyZBbSRLoOVKqmhBqSVFr2VTtTsLbPFMt7hE&msgID=I8065275063_1&markAsRead=
&copy; 2014, LinkedIn Corporation. 2029 Stierlin Ct. Mountain View, CA 94043, USA