Merge ~ziyiwang/charm-prometheus-libvirt-exporter:lint-20.08 into charm-prometheus-libvirt-exporter:master

Proposed by Celia Wang
Status: Merged
Approved by: Xav Paice
Approved revision: 0621d345d82c972d6ec9dc4d7e5e9de4142fdca5
Merged at revision: 719694f60eb28c7f5b8fb684e6fd2be580ae439c
Proposed branch: ~ziyiwang/charm-prometheus-libvirt-exporter:lint-20.08
Merge into: charm-prometheus-libvirt-exporter:master
Diff against target: 73 lines (+12/-8)
3 files modified
src/reactive/prometheus-libvirt-exporter.py (+2/-1)
src/tests/functional/tests/test_prometheus_libvirt_exporter.py (+6/-2)
src/tox.ini (+4/-5)
Reviewer Review Type Date Requested Status
Xav Paice (community) Approve
Canonical IS Reviewers Pending
BootStack Reviewers Pending
Review via email: mp+389054@code.staging.launchpad.net

Commit message

Extra Linting completed for 20.08 charm release

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Xav Paice (xavpaice) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 719694f60eb28c7f5b8fb684e6fd2be580ae439c

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: