Merge ~ziyiwang/charm-prometheus-libvirt-exporter:makefile-20.08 into charm-prometheus-libvirt-exporter:master

Proposed by Celia Wang
Status: Merged
Approved by: Xav Paice
Approved revision: c6535a87e140e39fc0b66b8212940282c5164c47
Merged at revision: 9c893a21395ff10041cf3aabf77d65e129ac2a3b
Proposed branch: ~ziyiwang/charm-prometheus-libvirt-exporter:makefile-20.08
Merge into: charm-prometheus-libvirt-exporter:master
Diff against target: 390 lines (+154/-94)
5 files modified
.gitignore (+26/-9)
Makefile (+60/-24)
dev/null (+0/-59)
src/tests/functional/tests/test_prometheus_libvirt_exporter.py (+2/-2)
src/tox.ini (+66/-0)
Reviewer Review Type Date Requested Status
Xav Paice (community) Approve
Canonical IS Reviewers Pending
BootStack Reviewers Pending
Review via email: mp+388985@code.staging.launchpad.net

Commit message

Imported standard Makefile and tox.ini and fixed up tests

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Xav Paice (xavpaice) wrote :

LGTM.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 9c893a21395ff10041cf3aabf77d65e129ac2a3b

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: