Charm Helpers

Merge lp://staging/~zhhuabj/charm-helpers/lp1685788 into lp://staging/charm-helpers

lp1685788
Merge into devel

Proposed by Hua Zhang on 2017-07-05

Status:

Merged

Approved by:

Alex Kavanagh on 2017-07-11

Approved revision:

758

Merged at revision:

761

Proposed branch:

lp://staging/~zhhuabj/charm-helpers/lp1685788

Merge into:

lp://staging/charm-helpers

Diff against target:

36 lines (+15/-0)

2 files modified

charmhelpers/contrib/openstack/context.py (+12/-0)
tests/contrib/openstack/test_os_contexts.py (+3/-0)

To merge this branch:

bzr merge lp://staging/~zhhuabj/charm-helpers/lp1685788

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Alex Kavanagh (community)		2017-07-05	Approve on 2017-07-07
Review via email: mp+326824@code.staging.launchpad.net

Revision history for this message

Alex Kavanagh (ajkavanagh) wrote on 2017-07-05:

This is going to need more of a commit/merge message please. Why are these being added? The bug report has more information, but it would be very useful to future readers of the commit history of charm-helpers why these were added here. It's also not clear which context class this is being added to. Thanks.

review: Needs Fixing

lp://staging/~zhhuabj/charm-helpers/lp1685788 updated on 2017-07-05

758. By Hua Zhang on 2017-07-05

When the OpenStack clouds get bigger, more messaging transactions will happen,
which will cause more load on rabbitmq server. In order to mitigate this,
polling_interval rpc_response_timeout and report_interval values are important
to adjust accordingly to the size of OpenStack cluster.

So this patch supports setting those values in neutron-api centrally, then:

1, polling_interval
neutron-openvswitch charm gets polling_interval via it's relations and set it
in [agent] of ml2_conf.ini or openvswitch_agent.ini(>=Mitaka)

2, rpc_response_timeout
neutron-gateway charm gets rpc_response_timeout via it's relations and set it
in [default] of neutron.conf

3, report_interval
Both neutron-openvswitch charm and neutron-gateway charm get report_interval
via it's relations and set it in [agent] of neutron.conf

Thus we need to modifty charm-helpers to set those values in NeutronAPIContext,
too.

Revision history for this message

Hua Zhang (zhhuabj) wrote on 2017-07-05:

Hi Alex, I have updated commit/merge message, thanks for the review.

Revision history for this message

Alex Kavanagh (ajkavanagh) wrote on 2017-07-07:

The commit message now looks great. Thanks for fixing it up.

review: Approve