News Scope

Merge lp://staging/~zhangew401/news-scope/autopilot-news-scope into lp://staging/news-scope

  1. autopilot-news-scope
  2. Merge into trunk
Proposed by Zhang Enwei
Status: Merged
Approved by: Kyle Nitzsche
Approved revision: 40
Merged at revision: 41
Proposed branch: lp://staging/~zhangew401/news-scope/autopilot-news-scope
Merge into: lp://staging/news-scope
Diff against target: 512 lines (+312/-28)
13 files modified
make-click.sh (+71/-2)
po/bg.po (+2/-2)
po/cs.po (+2/-2)
po/en_GB.po (+3/-3)
po/eu.po (+2/-2)
po/ja.po (+3/-3)
po/ko.po (+3/-3)
po/pt_BR.po (+2/-2)
po/ro.po (+3/-3)
po/sk.po (+2/-2)
po/sv.po (+2/-2)
po/zh_CN.po (+2/-2)
tests/autopilot/test_generic.py.in (+215/-0)
To merge this branch: bzr merge lp://staging/~zhangew401/news-scope/autopilot-news-scope
Reviewer Review Type Date Requested Status
Kyle Nitzsche (community) Approve
Review via email: mp+284056@code.staging.launchpad.net

Description of the change

1. Fix missing translations in order to pass autopilot tests
2. Support autopilot tests
3. Bump version

To post a comment you must log in.
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi Enwei.
Line 12: fix typo. Should be "definition"

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Since supporting autopilot is new for agg scopes, and since the controlling vars for agg scopes are in the make_click.sh file (instead of the root CMakeLists.txt file for non agg scopes), can you please add something short and appropriate to the doc: https://docs.google.com/document/d/1ipD5csK_HWsJKqLh3oeCJdAW_o3hYNoN3JLAK77mOm0/edit#heading=h.8pso8fn1mz07

Probably in the "Implementing.. " section.

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi Enwei.

Looks good (I have not tested the code). Please just fix the typo and add to the doc as noted in my two comments.

Cheers

review: Approve
Revision history for this message
Zhang Enwei (zhangew401) wrote :

Thank you so much Kyle.
Will update soon.

On Tue, Feb 2, 2016 at 12:20 AM, Kyle Nitzsche <email address hidden>
wrote:

> The proposal to merge lp:~zhangew401/news-scope/autopilot-news-scope into
> lp:news-scope has been updated.
>
> Status: Needs review => Approved
>
> For more details, see:
>
> https://code.launchpad.net/~zhangew401/news-scope/autopilot-news-scope/+merge/284056
> --
> You are the owner of lp:~zhangew401/news-scope/autopilot-news-scope.
>

lp://staging/~zhangew401/news-scope/autopilot-news-scope updated
41. By Zhang Enwei <email address hidden>

1 Fix typo. 2 move to autopilot folder. 3 Add TEST_DEPARTMENTS_SURFACE to control the test of department results

Revision history for this message
Zhang Enwei (zhangew401) wrote :

Hi Kyle,
I have tested the test cases, it works well.
Please have a review of the document,
https://docs.google.com/document/d/1ipD5csK_HWsJKqLh3oeCJdAW_o3hYNoN3JLAK77mOm0/edit#
Thanks a lot.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: