qtcreator-plugin-ubuntu

Merge lp://staging/~zeller-benjamin/qtcreator-plugin-ubuntu/fat-packaging-strings into lp://staging/qtcreator-plugin-ubuntu

  1. fat-packaging-strings
  2. Merge into trunk
Proposed by Benjamin Zeller
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 361
Merged at revision: 356
Proposed branch: lp://staging/~zeller-benjamin/qtcreator-plugin-ubuntu/fat-packaging-strings
Merge into: lp://staging/qtcreator-plugin-ubuntu
Diff against target: 256 lines (+63/-27)
4 files modified
share/qtcreator/ubuntu/scripts/qtc_chroot_wrapper.py (+10/-2)
src/ubuntu/ubuntupackagingmodel.cpp (+3/-3)
src/ubuntu/wizards/ubuntufatpackagingwizard.cpp (+36/-20)
src/ubuntu/wizards/ubuntufatpackagingwizard.h (+14/-2)
To merge this branch: bzr merge lp://staging/~zeller-benjamin/qtcreator-plugin-ubuntu/fat-packaging-strings
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Zoltan Balogh Approve
Review via email: mp+250594@code.staging.launchpad.net

Commit message

- Use more verbose strings to explain the fat packaging wizard
- Fix a uncatched exception in click_chroot_wrapper.py lp:1424043
- Do not close prespawned sessions in click_chroot_wrapper when the
script receives a SIGTERM

Description of the change

- Use more verbose strings to explain the fat packaging wizard
- Fix a uncatched exception in click_chroot_wrapper.py lp:1424043
- Do not close prespawned sessions in click_chroot_wrapper when the
script receives a SIGTERM

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:359
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/521/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-amd64-ci/55
        deb: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-amd64-ci/55/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-armhf-ci/55

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/521/rebuild

review: Approve (continuous-integration)
lp://staging/~zeller-benjamin/qtcreator-plugin-ubuntu/fat-packaging-strings updated
360. By Benjamin Zeller

header

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:360
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/522/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-amd64-ci/56
        deb: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-amd64-ci/56/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-armhf-ci/56

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/522/rebuild

review: Approve (continuous-integration)
lp://staging/~zeller-benjamin/qtcreator-plugin-ubuntu/fat-packaging-strings updated
361. By Benjamin Zeller

- Fix a uncatched exception in click_chroot_wrapper.py lp:1424043
- Do not close prespawned sessions in click_chroot_wrapper when the
script receives a SIGTERM

Revision history for this message
Zoltan Balogh (bzoltan) wrote :

OK, let's silo it and check again all bits.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:361
http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-ci/523/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-amd64-ci/57
        deb: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-amd64-ci/57/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtcreator-plugin-ubuntu-vivid-armhf-ci/57

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtcreator-plugin-ubuntu-ci/523/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches