Merge lp://staging/~yuningdodo/usb-creator/usb-creator.lp1325801-sync-syslinux-c32-files into lp://staging/ubuntu/vivid/usb-creator
Proposed by
Yu Ning
Status: | Rejected |
---|---|
Rejected by: | Mathieu Trudel-Lapierre |
Proposed branch: | lp://staging/~yuningdodo/usb-creator/usb-creator.lp1325801-sync-syslinux-c32-files |
Merge into: | lp://staging/ubuntu/vivid/usb-creator |
Diff against target: |
28 lines (+11/-0) 1 file modified
usbcreator/install.py (+11/-0) |
To merge this branch: | bzr merge lp://staging/~yuningdodo/usb-creator/usb-creator.lp1325801-sync-syslinux-c32-files |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Yu Ning (community) | Disapprove | ||
Mathieu Trudel-Lapierre | Needs Fixing | ||
usb-creator hackers | Pending | ||
Review via email: mp+249454@code.staging.launchpad.net |
Description of the change
Make sure we use the same version of mbr.bin and syslinux *.c32 files. (LP: #1325801)
This patch was originally uploaded in bug #1325801 comment #83, I have made some tests on trusty, it can correctly create the usbstick for ubuntu 12.04, 14.10, etc., and even xubuntu.
To post a comment you must log in.
Could you please resubmit these changes a against lp:~usb-creator-hackers/usb-creator/trunk?
I'm not sure this is going to fix things for writing pre-14.10 images using a 14.10 system; the files are now split into directories which probably ought to be taken into account as well. By my initial testing, just copying the directory or the files over in syslinux/ directly don't seem to fix this, but it also only affects non-EFI boots.
You've tested writing various images from trusty. Have you also tested writing, for example, a trusty image from utopic, to see if the resulting image can be properly booted?