subunit

Merge lp://staging/~yellow/subunit/on_filter into lp://staging/~subunit/subunit/trunk

  1. on_filter
  2. Merge into trunk
Proposed by Gary Poster
Status: Rejected
Rejected by: Robert Collins
Proposed branch: lp://staging/~yellow/subunit/on_filter
Merge into: lp://staging/~subunit/subunit/trunk
Diff against target: 96 lines (+22/-7)
2 files modified
python/subunit/test_results.py (+11/-7)
python/subunit/tests/test_subunit_filter.py (+11/-0)
To merge this branch: bzr merge lp://staging/~yellow/subunit/on_filter
Reviewer Review Type Date Requested Status
Robert Collins Disapprove
Review via email: mp+103968@code.staging.launchpad.net

Description of the change

This branch adds an on_filter keyword argument to TestResultFilter. This is intended to be an approach that can significantly simplify the TestResultFilter subclass in testrepository now, and fix test failures in testrepository when lp:~jml/subunit/filter-tags is merged.

This MP replaces https://code.launchpad.net/~yellow/subunit/test-count/+merge/103717 , and the comments in that MP point to why this branch is of interest to us.

Thank you

To post a comment you must log in.
Revision history for this message
Gary Poster (gary) wrote :

https://code.launchpad.net/~yellow/testrepository/on_filter/+merge/103969 depends on these changes.

Revision history for this message
Jonathan Lange (jml) wrote :

Is this still needed?

Revision history for this message
Gary Poster (gary) wrote :

Short answer: yes, I think so. The longer answer is in the other related on_filter branch.

Revision history for this message
Robert Collins (lifeless) wrote :

The count thing in testrepository is best solved by using MultiTestResult and forking the streams rather than fiddling with internals in the filter; the comment in the existing class there explains this.

review: Disapprove
Revision history for this message
Robert Collins (lifeless) wrote :

This might be interesting in its own right but we have no current use case for it. Until we do I'd rather keep things lean.

Unmerged revisions

165. By Gary Poster

make explicit way to call code in TestResultFilter for each test that does not pass through the filter.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches