Merge ~ycheng-twn/ubuntu/+source/ubiquity:0001_mark_install_enhancement into ubuntu/+source/ubiquity:ubuntu/devel

Proposed by Yuan-Chen Cheng
Status: Needs review
Proposed branch: ~ycheng-twn/ubuntu/+source/ubiquity:0001_mark_install_enhancement
Merge into: ubuntu/+source/ubiquity:ubuntu/devel
Diff against target: 28 lines (+15/-2)
1 file modified
ubiquity/install_misc.py (+15/-2)
Reviewer Review Type Date Requested Status
Julian Andres Klode (community) Disapprove
git-ubuntu developers Pending
Review via email: mp+390009@code.staging.launchpad.net

Commit message

This fix LP: #1891599. please check there for details.

To post a comment you must log in.
Revision history for this message
Julian Andres Klode (juliank) wrote :

Both the original approach as well as the proposed one are wrong. The correct approach for marking multiple packages for installation is to

1. mark all the packages with auto_inst=False, auto_fix=False
2. mark all the packages with auto_inst=True, auto_fix=False
3. run a ProblemResolver manually

This ensures that choices are propagated correctly, if you install A, B and A depends on C|B, this would install A and B, whereas the other algorithms install A, C, and B.

review: Disapprove

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches