OpenERP Community Backports (Server)

Merge lp://staging/~yann-papouin/ocb-server/7.0-bug-1049653-translatable-unaccent into lp://staging/ocb-server

  1. 7.0-bug-1049653-translatable-unaccent
  2. Merge into 7.0
Proposed by Yann Papouin
Status: Rejected
Rejected by: Stefan Rijnhart (Opener)
Proposed branch: lp://staging/~yann-papouin/ocb-server/7.0-bug-1049653-translatable-unaccent
Merge into: lp://staging/ocb-server
Diff against target: 27 lines (+12/-5)
1 file modified
openerp/osv/expression.py (+12/-5)
To merge this branch: bzr merge lp://staging/~yann-papouin/ocb-server/7.0-bug-1049653-translatable-unaccent
Reviewer Review Type Date Requested Status
Raphaël Valyi - http://www.akretion.com Needs Information
Pedro Manuel Baeza code review Approve
Holger Brunn (Therp) code review Approve
Review via email: mp+210165@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

mutatis mutandis the same as ocb-6.1

review: Approve (code review)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thanks for the patch.

Regards.

review: Approve (code review)
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

Hello,

somebody to compare with existing MP from Cloves Almeida and take the best one?
https://code.launchpad.net/~cmsa/openobject-server/openobject-server-7.0-fix-unaccent/+merge/197810

review: Needs Information
Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

I mean Carlos Almeida sorry.

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Raphaël,

As far as I can see, Carlos Almeida patch is incomplete, because it doesn't take in account certain values that can be unaccented too.

Indeed, this solution applies unaccent indiscriminately (even to the left part of the comparison), but I think it's done in this way to follow official patch.

Regards.

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Setting to 'rejected' because an alternative fix was merged here: http://bazaar.launchpad.net/~openerp/openobject-server/7.0/revision/5268. Nevertheless, thanks for the proposal!

Unmerged revisions

5284. By Damián Soriano (damiansoriano)

[FIX] --unaccent parameter does not work

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: