OpenERP Community Backports (Addons)

Merge lp://staging/~yann-papouin/ocb-addons/7.0-bug-1169074-pricelist-category-depth into lp://staging/ocb-addons

  1. 7.0-bug-1169074-pricelist-category-depth
  2. Merge into 7.0
Proposed by Yann Papouin
Status: Rejected
Rejected by: Holger Brunn (Therp)
Proposed branch: lp://staging/~yann-papouin/ocb-addons/7.0-bug-1169074-pricelist-category-depth
Merge into: lp://staging/ocb-addons
Diff against target: 70 lines (+37/-14)
1 file modified
product/pricelist.py (+37/-14)
To merge this branch: bzr merge lp://staging/~yann-papouin/ocb-addons/7.0-bug-1169074-pricelist-category-depth
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Disapprove
Guewen Baconnier @ Camptocamp Needs Information
Yannick Vaucher @ Camptocamp code review, no test Approve
Review via email: mp+210163@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

same as 6.1-ocb

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Thanks for the job done

LGTM as clone of https://code.launchpad.net/~yann-papouin/ocb-addons/6.1-bug-1169074-pricelist-category-depth/+merge/184510

review: Approve (code review, no test)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

As you needed to rewrite the query, isn't in an opportunity to remove the injection of the ids in the query and use params in execute()? Even though categ_ids are supposed to be safe here, the correct way is to use the query parameters.

review: Needs Information
Revision history for this message
Yann Papouin (yann-papouin) wrote :

It does not seems to be simple to parameterize this query.
Maybe this change could be made in another proposal and this one could be merged now ?

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Development for 7.0 has moved to github on https://github.com/OCA/ocb - please move your merge proposal there if it is still valid.

(I close and reject this in order to have a cleaner overview for 6.1 MPs which indeed have to be done on launchpad)

review: Disapprove

Unmerged revisions

9986. By Yann Papouin

[FIX] Pricelist doesn't take category depth into account

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.