OpenERP Community Backports (Addons)

Merge lp://staging/~yann-papouin/ocb-addons/6.1-bug-997642-fix-services-make-to-stock into lp://staging/ocb-addons/6.1

  1. 6.1-bug-997642-fix-services-make-to-stock
  2. Merge into 6.1
Proposed by Yann Papouin
Status: Merged
Merged at revision: 6838
Proposed branch: lp://staging/~yann-papouin/ocb-addons/6.1-bug-997642-fix-services-make-to-stock
Merge into: lp://staging/ocb-addons/6.1
Diff against target: 33 lines (+6/-3)
1 file modified
project_mrp/project_procurement.py (+6/-3)
To merge this branch: bzr merge lp://staging/~yann-papouin/ocb-addons/6.1-bug-997642-fix-services-make-to-stock
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Holger Brunn (Therp) code review Approve
Review via email: mp+203903@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

#19 should this be p.product_id.procure_method?

review: Needs Fixing (code review)
Revision history for this message
Yann Papouin (yann-papouin) wrote :

No, the procure_method is stored in the procurement object when created.
https://bugs.launchpad.net/ocb-addons/+bug/997642/comments/7

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Thanks for your pointer and sorry for overlooking!

review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches