OpenERP Community Backports (Addons)

Merge lp://staging/~yann-papouin/ocb-addons/6.1-bug-1169074-pricelist-category-depth into lp://staging/ocb-addons/6.1

  1. 6.1-bug-1169074-pricelist-category-depth
  2. Merge into 6.1
Proposed by Yann Papouin
Status: Merged
Merged at revision: 6812
Proposed branch: lp://staging/~yann-papouin/ocb-addons/6.1-bug-1169074-pricelist-category-depth
Merge into: lp://staging/ocb-addons/6.1
Diff against target: 76 lines (+38/-14)
1 file modified
product/pricelist.py (+38/-14)
To merge this branch: bzr merge lp://staging/~yann-papouin/ocb-addons/6.1-bug-1169074-pricelist-category-depth
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Approve
Review via email: mp+184510@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

I think your code is fine.

But it would be very unfortunate to have this feature in 6.1 and loose it when stepping over to 7.0, so please also provide an MP effecting the same change for 7.0.

review: Approve
Revision history for this message
Yann Papouin (yann-papouin) wrote :

Thank you for your review.

It's not easy for me to make MP for 7.0 as our company is not using it, we are using 6.1 in production/daily use for our specific needs since 01/2013, and I'm fixing bugs as soon as they can be traced.

It would be hard to me to justify my work time on something that is not used by my company to my employer.
Worse, as I don't really follow 7.0/trunk code evolution, I prefer not making any MP to avoid any error as I don't have any code introspection experience on these versions.

I think that my MP is enough to help anyone to create it's own MP from his 7.0's experience.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches