OpenERP Community Backports (Addons)

Merge lp://staging/~yann-papouin/ocb-addons/6.1-bug-1048547-product-variant-supplierinfo-pricelist into lp://staging/ocb-addons/6.1

  1. 6.1-bug-1048547-product-variant-supplierinfo-pricelist
  2. Merge into 6.1
Proposed by Yann Papouin
Status: Merged
Approved by: Holger Brunn (Therp)
Approved revision: no longer in the source branch.
Merged at revision: 6833
Proposed branch: lp://staging/~yann-papouin/ocb-addons/6.1-bug-1048547-product-variant-supplierinfo-pricelist
Merge into: lp://staging/ocb-addons/6.1
Diff against target: 25 lines (+2/-2)
2 files modified
product/pricelist.py (+1/-1)
purchase/purchase.py (+1/-1)
To merge this branch: bzr merge lp://staging/~yann-papouin/ocb-addons/6.1-bug-1048547-product-variant-supplierinfo-pricelist
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Stefan Rijnhart (Opener) Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+205161@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

I have never faced this problem, but I don't use variants. Seems OK.

Regards.

review: Approve (code review)
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Yes, I have run into problems because I assumed supplierinfo's product_id field refers to product_product while it actually refers to product_template. So the solution seems correct to me.

I checked 7.0 and the change in product/pricelist.py is there, while purchase/purchase.py's onchange_product_id() has been rewritten so that it evades the problem which is fixed in this change.

review: Approve
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches