Merge ~yann-ilas/maas:master into maas:master

Proposed by Yann Ilas
Status: Work in progress
Proposed branch: ~yann-ilas/maas:master
Merge into: maas:master
Diff against target: 263 lines (+67/-21)
3 files modified
src/provisioningserver/drivers/hardware/ucsm.py (+20/-9)
src/provisioningserver/drivers/power/tests/test_ucsm.py (+11/-5)
src/provisioningserver/drivers/power/ucsm.py (+36/-7)
Reviewer Review Type Date Requested Status
MAAS Lander Needs Fixing
Björn Tillenius Needs Information
Review via email: mp+401620@code.staging.launchpad.net

This proposal supersedes a proposal from 2021-04-22.

To post a comment you must log in.
Revision history for this message
Yann Ilas (yann-ilas) wrote : Posted in a previous version of this proposal

As suggested by these issues (https://bugs.launchpad.net/maas/+bug/1700180 and https://bugs.launchpad.net/maas/+bug/1915835), I suggest the possibility to add the field "API protocol (optional)".
The idea is to have the same behavior than the vmware module where the value "https+unverified" can be added to bypass the check of the certificate (for instance, we can use self-signed certificate).

Revision history for this message
MAAS Lander (maas-lander) wrote : Posted in a previous version of this proposal

UNIT TESTS
-b master lp:~yann-ilas/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/9830/console
COMMIT: f7fdb4ce9ba8f13c5c47bfc08bab862534c61cce

review: Needs Fixing
Revision history for this message
Adam Collard (adam-collard) wrote : Posted in a previous version of this proposal

https://paste.ubuntu.com/p/CDsWMwfSdz/ output from the CI job - please run `make format` to fix up the lint issues

Revision history for this message
MAAS Lander (maas-lander) wrote : Posted in a previous version of this proposal

UNIT TESTS
-b master lp:~yann-ilas/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/9831/console
COMMIT: 436bdf4adb07776b9b76814ec52e0bf17ac9abe3

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote : Posted in a previous version of this proposal

UNIT TESTS
-b master lp:~yann-ilas/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/9832/console
COMMIT: 3c383a7f71f68f05546efb2e7f2ba037c73bf037

review: Needs Fixing
Revision history for this message
Yann Ilas (yann-ilas) wrote : Posted in a previous version of this proposal

The review is set to "Needs Fixing" but I can't find where is that issue.
Can you bring me some help ?

Le jeu. 22 avr. 2021 à 14:48, MAAS Lander <email address hidden> a
écrit :

> Review: Needs Fixing
>
> UNIT TESTS
> -b master lp:~yann-ilas/maas/+git/maas into -b master
> lp:~maas-committers/maas
>
> STATUS: FAILED
> LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/9832/console
> COMMIT: 3c383a7f71f68f05546efb2e7f2ba037c73bf037
> --
> https://code.launchpad.net/~yann-ilas/maas/+git/maas/+merge/401603
> You are the owner of ~yann-ilas/maas:master.
>

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b master lp:~yann-ilas/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/9835/console
COMMIT: 3c383a7f71f68f05546efb2e7f2ba037c73bf037

review: Needs Fixing
Revision history for this message
Björn Tillenius (bjornt) wrote :

Before I do a proper review, I have a question inline.

review: Needs Information
Revision history for this message
Yann Ilas (yann-ilas) wrote :

Please find inline a reply to your question. Thanks !

Revision history for this message
Björn Tillenius (bjornt) :
Revision history for this message
Adam Collard (adam-collard) wrote :

@Yann thank you for your contribution - please can you respond to Björn's comments from 2021-04-27 and update your branch?

Revision history for this message
Yann Ilas (yann-ilas) wrote :

> @Yann thank you for your contribution - please can you respond to Björn's
> comments from 2021-04-27 and update your branch?

Hi @Adam. Sorry for the delay. I will send you an update tomorrow.

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b master lp:~yann-ilas/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10776/console
COMMIT: 85afe1a34ba68b3e94ce766ca058352fd9e7209a

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b master lp:~yann-ilas/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10777/console
COMMIT: 55750a831e5705797ef4baeb094c8b6505898eef

review: Needs Fixing
Revision history for this message
Yann Ilas (yann-ilas) wrote :

Hi @Adam,

I get an error during the last commit. How can I have the detail of the error ?

> LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10776/console
> COMMIT: 85afe1a34ba68b3e94ce766ca058352fd9e7209a

Revision history for this message
Adam Collard (adam-collard) wrote (last edit ):

> Hi @Adam,
>
> I get an error during the last commit. How can I have the detail of the error
> ?
>
> > LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10776/console
> > COMMIT: 85afe1a34ba68b3e94ce766ca058352fd9e7209a

 + git clone --depth 100 --single-branch --branch master git+ssh://<email address hidden>/~maas-committers/maas maas
 Cloning into 'maas'...
 Warning: Permanently added 'git.launchpad.net,91.189.94.77' (RSA) to the list of known hosts.
 + cd maas
 + git remote add source git+ssh://<email address hidden>/~yann-ilas/maas/+git/maas
 + git fetch --depth 100 source master
 Warning: Permanently added 'git.launchpad.net,91.189.94.79' (RSA) to the list of known hosts.
 warning: no common commits
 From git+ssh://git.launchpad.net/~yann-ilas/maas/+git/maas
  * branch master -> FETCH_HEAD
  * [new branch] master -> source/master
 + git show --format=%aE source/master -q
 + git config user.email <email address hidden>
 + git show --format=%aN source/master -q
 + git config user.name ILAS Yann
 + git merge --squash source/master
 fatal: refusing to merge unrelated histories

Try rebasing on top of latest master

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches