Merge lp://staging/~ya-bo-ng/ubuntu-webcatalog/description-styling-update into lp://staging/ubuntu-webcatalog

Proposed by Anthony Dillon
Status: Rejected
Rejected by: Natalia Bidart
Proposed branch: lp://staging/~ya-bo-ng/ubuntu-webcatalog/description-styling-update
Merge into: lp://staging/ubuntu-webcatalog
Diff against target: 11 lines (+1/-0)
1 file modified
src/webcatalog/static/css/webcatalog.css (+1/-0)
To merge this branch: bzr merge lp://staging/~ya-bo-ng/ubuntu-webcatalog/description-styling-update
Reviewer Review Type Date Requested Status
Canonical Consumer Applications Hackers Pending
Review via email: mp+213799@code.staging.launchpad.net

Description of the change

Added line height to the app description styling to increase legibility.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Setting MP as Rejected to reduce numbers of landing candidates in @reviewlist.
Change status again if this MP is still current.

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Natalia,

Why has this MP been rejected instead of reviewed? If you feel this is not a vaild fix then can you state the issue and I'll address your comments.

Thanks,
Ant.

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Hello Anthony!

I applied a general filter to all MPs older than 500 days without activity to be Rejected, explaining to the submitter that they can set it as Needs Fixing again if they consider the MP is still current and valid.

For this particular project, there are no plans to make changes to the current code running in production, nor have any change been applied in a very long time, so IMHO there is no point in merging an MP that will not be released to production.

If you still think the MP should be accepted, please set it as Needs Review and raise it in the Online Services IRC channel.

Thank you for your contributions!
Natalia.

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Thanks Natalia,

I wasn't aware there was no further development on this site. I agree there is no point merging this branch if it will not be released.

Is this site due to be taken down? The web team receive bugs about this site. What would you suggest we do in this case?

Thanks,
Any.

Unmerged revisions

197. By Anthony Dillon

Add line height to the app descriptions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches