Merge lp://staging/~ya-bo-ng/ubuntu-html5-theme/sass-setup into lp://staging/ubuntu-html5-theme

Proposed by Anthony Dillon
Status: Merged
Approved by: Alexandre Abreu
Approved revision: 140
Merged at revision: 146
Proposed branch: lp://staging/~ya-bo-ng/ubuntu-html5-theme/sass-setup
Merge into: lp://staging/ubuntu-html5-theme
Diff against target: 3698 lines (+1746/-1721)
39 files modified
.bzrignore (+1/-0)
0.1/ambiance/css/appTemplate.css (+1/-23)
0.1/ambiance/css/buttons.css (+0/-96)
0.1/ambiance/css/default.css (+0/-128)
0.1/ambiance/css/dialogs.css (+0/-169)
0.1/ambiance/css/icons.css (+0/-37)
0.1/ambiance/css/indexbar.css (+0/-60)
0.1/ambiance/css/listitems.css (+0/-151)
0.1/ambiance/css/option-selector.css (+0/-137)
0.1/ambiance/css/pagestack.css (+0/-46)
0.1/ambiance/css/popover.css (+0/-125)
0.1/ambiance/css/progress-bars.css (+0/-96)
0.1/ambiance/css/reset.css (+0/-112)
0.1/ambiance/css/sass/buttons.scss (+95/-0)
0.1/ambiance/css/sass/constants.scss (+26/-0)
0.1/ambiance/css/sass/default.scss (+131/-0)
0.1/ambiance/css/sass/dialogs.scss (+167/-0)
0.1/ambiance/css/sass/icons.scss (+37/-0)
0.1/ambiance/css/sass/indexbar.scss (+59/-0)
0.1/ambiance/css/sass/listitems.scss (+145/-0)
0.1/ambiance/css/sass/mixins.scss (+31/-0)
0.1/ambiance/css/sass/option-selector.scss (+136/-0)
0.1/ambiance/css/sass/pagestack.scss (+45/-0)
0.1/ambiance/css/sass/popover.scss (+124/-0)
0.1/ambiance/css/sass/progress-bars.scss (+91/-0)
0.1/ambiance/css/sass/reset.scss (+112/-0)
0.1/ambiance/css/sass/shapes.scss (+62/-0)
0.1/ambiance/css/sass/sliders.scss (+50/-0)
0.1/ambiance/css/sass/tabs.scss (+100/-0)
0.1/ambiance/css/sass/text-input.scss (+77/-0)
0.1/ambiance/css/sass/toggles.scss (+148/-0)
0.1/ambiance/css/sass/toolbars.scss (+80/-0)
0.1/ambiance/css/shapes.css (+0/-62)
0.1/ambiance/css/sliders.css (+0/-53)
0.1/ambiance/css/tabs.css (+0/-102)
0.1/ambiance/css/text-input.css (+0/-98)
0.1/ambiance/css/toggles.css (+0/-146)
0.1/ambiance/css/toolbars.css (+0/-80)
README (+28/-0)
To merge this branch: bzr merge lp://staging/~ya-bo-ng/ubuntu-html5-theme/sass-setup
Reviewer Review Type Date Requested Status
Alexandre Abreu Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+206764@code.staging.launchpad.net

Commit message

SASS setup

Description of the change

I have created a README file with instructions to set up the sass watcher to develop the components.

Converted all the css files into scss with nesting.

Added a few common variables and mixins.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

For me, in the ui-gallery, the toolbar item and the toggles item w/ the disabled style break (compared to what's in trunk)

review: Needs Fixing
139. By Anthony Dillon

Few small tweaks to fix the convertion to sass

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
140. By Anthony Dillon

Fixed text inputs and toolbar styles

Revision history for this message
Alexandre Abreu (abreu-alexandre) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches