Whoopsie

Merge lp://staging/~xnox/whoopsie/stable-id-through-boot into lp://staging/whoopsie

stable-id-through-boot
Merge into trunk

Proposed by Dimitri John Ledkov on 2014-08-05

Status:

Merged

Merged at revision:

634

Proposed branch:

lp://staging/~xnox/whoopsie/stable-id-through-boot

Merge into:

lp://staging/whoopsie

Diff against target:

187 lines (+94/-2)

4 files modified

src/identifier.c (+33/-1)
src/identifier.h (+4/-0)
src/tests/test_identifier.c (+53/-0)
src/whoopsie.c (+4/-1)

To merge this branch:

bzr merge lp://staging/~xnox/whoopsie/stable-id-through-boot

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Brian Murray (community)	2014-08-05	Approve on 2014-09-17
John Lenton (community)	2014-08-05	Needs Fixing on 2014-08-05
Review via email: mp+229593@code.staging.launchpad.net

Revision history for this message

John Lenton (chipaca) wrote on 2014-08-05:

A bug and a question, inline.

review: Needs Fixing

Revision history for this message

Dimitri John Ledkov (xnox) wrote on 2014-08-05:

Replied inline.

lp://staging/~xnox/whoopsie/stable-id-through-boot updated on 2014-08-05

627. By Dimitri John Ledkov on 2014-08-05

Make whoopsie_identifier_generate() stable throughout the system boot.

That means, whilst whoopsied is running that api call will return the
current ID used by whoopsie itself, irrespective if the caller is root
or non-root, and additional MAC network interfaces or IMEI modems
appearing, and takes into consideration if custom system id was set.

628. By Dimitri John Ledkov on 2014-08-05

Drop unlink.

Revision history for this message

Brian Murray (brian-murray) wrote on 2014-09-17:

It seems to me that in whoopsie.c we could check to see if whoopsie_identifier is the same as the one in the existing WHOOPSIE_ID_PATH (if it exists) rather than writing it again. Otherwise, this looks good and I'll merge and upload it. Thanks!

review: Approve

Revision history for this message

Dimitri John Ledkov (xnox) wrote on 2014-09-17:

did I change the cache path from /run to somewhere persistent? if not, do
update it. I recall discussing /var/lib/ or some such.
On 17 Sep 2014 20:48, "Brian Murray" <email address hidden> wrote:

> Review: Approve
>
> It seems to me that in whoopsie.c we could check to see if
> whoopsie_identifier is the same as the one in the existing WHOOPSIE_ID_PATH
> (if it exists) rather than writing it again. Otherwise, this looks good
> and I'll merge and upload it. Thanks!
> --
>
> https://code.launchpad.net/~xnox/whoopsie/stable-id-through-boot/+merge/229593
> You are the owner of lp:~xnox/whoopsie/stable-id-through-boot.
>