Merge lp://staging/~xnox/upstart/test-static into lp://staging/upstart
Proposed by
Dimitri John Ledkov
| Status: | Merged |
|---|---|
| Merged at revision: | 1420 |
| Proposed branch: | lp://staging/~xnox/upstart/test-static |
| Merge into: | lp://staging/upstart |
| Diff against target: |
229 lines (+100/-55) 5 files modified
init/Makefile.am (+15/-0) init/conf.c (+4/-4) init/conf.h (+0/-3) init/tests/test_conf.c (+0/-48) init/tests/test_conf_static.c (+81/-0) |
| To merge this branch: | bzr merge lp://staging/~xnox/upstart/test-static |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| James Hunt | Approve | ||
|
Review via email:
|
|||
Description of the change
Unit-tests should not force one to make functions public.
There are no excuses to not unit-test static functions ;-)
Also unit-tests should not modify code.
=))))))
/me wants this, as I will be adding more static functions for override handling & want to unit test them.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM - merged.