Merge lp://staging/~xnox/upstart/read-vs-sigchild into lp://staging/upstart

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 1651
Proposed branch: lp://staging/~xnox/upstart/read-vs-sigchild
Merge into: lp://staging/upstart
Diff against target: 101 lines (+65/-2)
1 file modified
init/tests/test_job_process.c (+65/-2)
To merge this branch: bzr merge lp://staging/~xnox/upstart/read-vs-sigchild
Reviewer Review Type Date Requested Status
Dimitri John Ledkov (community) Needs Fixing
Review via email: mp+226560@code.staging.launchpad.net

Description of the change

This should resolve racy test failure as seen on arm64:

not ok 16 - with no such file
 wrong content in file 0x557c0b1480 (output), expected 'test: Failed to spawn test (foo) main process: unable to execute: No such file or directory
' got 'test: test (foo) main process (348) terminated with status 255
'
 at tests/test_job_process.c:1205 (test_start).

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Haha, and it didn't:

not ok 16 - with no such file (read error)
 wrong content in file 0x55c91bf480 (output), expected 'test: Failed to spawn test (foo) main process: unable to execute: No such file or directory
' got 'test: test (foo) main process (14635) terminated with status 255
'
 at tests/test_job_process.c:1220 (test_start).
1..153

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches