Merge lp://staging/~xnox/ubuntu/vivid/upstart/fix-rotate-logs into lp://staging/ubuntu/vivid/upstart

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 1598
Proposed branch: lp://staging/~xnox/ubuntu/vivid/upstart/fix-rotate-logs
Merge into: lp://staging/ubuntu/vivid/upstart
Diff against target: 68 lines (+25/-7)
3 files modified
debian/changelog (+11/-0)
debian/control (+2/-2)
debian/upstart-bin.upstart.cron.daily (+12/-5)
To merge this branch: bzr merge lp://staging/~xnox/ubuntu/vivid/upstart/fix-rotate-logs
Reviewer Review Type Date Requested Status
Martin Pitt Needs Information
James Hunt Pending
Ubuntu branches Pending
Review via email: mp+246052@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

Looks good to me, thanks!

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

BTW, how does emitting ":sys:*" events go along with https://code.launchpad.net/~xnox/upstart/no-classes/+merge/245948 ? I thought they should drop the :sys prefix now?

review: Needs Information
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

@pitti:
I'm going for a mix here.
udev-bridge is moving from system-init -> session-init, thus dropping :sys: prefix.
local-bridge will stay running under system-init (either systemd or upstart), thus will keep :sys: prefix
rotate-logs emitage moved from system-init -> session-init, thus dropps :sys: prefix.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches