Ubuntu
nuntium package

Merge lp://staging/~xnox/ubuntu/vivid/nuntium/drop-sys-events into lp://staging/ubuntu/vivid/nuntium

  1. Vivid (15.04)
  2. drop-sys-events
  3. Merge into vivid
Proposed by Dimitri John Ledkov
Status: Rejected
Rejected by: Iain Lane
Proposed branch: lp://staging/~xnox/ubuntu/vivid/nuntium/drop-sys-events
Merge into: lp://staging/ubuntu/vivid/nuntium
Diff against target: 31 lines (+13/-2)
2 files modified
debian/changelog (+7/-0)
debian/nuntium.conf (+6/-2)
To merge this branch: bzr merge lp://staging/~xnox/ubuntu/vivid/nuntium/drop-sys-events
Reviewer Review Type Date Requested Status
Iain Lane (community) Needs Resubmitting
James Hunt Pending
Martin Pitt Pending
Sergio Schvezov Pending
Oliver Grawert Pending
Review via email: mp+246051@code.staging.launchpad.net

Commit message

Migrate from :sys:started events to dbus owner signals.

Description of the change

Migrate from :sys:started events to dbus owner signals.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

When system upstart goes away, :sys:started/stopped/starting/stopping events will go away.

One option is to introduce a user session event bridge which will relay similar events from systemd. I have a working prototype for that, however incomplete information is exposed by systemd at the moment.

Another option is to key onto approximately equivalent events which are already available.

This is a master bug to track all users and port them.

Revision history for this message
Sebastien Bacher (seb128) wrote :

could somebody review that change?

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

dunno, let me try my colleague james...

Revision history for this message
James Hunt (jamesodhunt) wrote :

I can't test this, but looks good in principle.

Revision history for this message
Martin Pitt (pitti) wrote :

I haven't tested this either, how can this be done? "I get a bubble for receiving an SMS", or is it only an MMS as the package description says?

But it looks good indeed.

Revision history for this message
Iain Lane (laney) wrote :

Shouldn't this be on lp:nuntium? Can you re-file it there?

What does "''" mean? Empty string or wildcard?

review: Needs Resubmitting
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

@Laney and what is https://code.launchpad.net/~xnox/nuntium/drop-sys-events/+merge/246049 ?

Please merge this already........ somehow..... it's been 8 months now.

Note that the "dbus" even is the same in both start on and stop condition. The difference between them are the ARG1/ARG2, when a name is acquired it goes from empty -> something rather (unique dbus object name); when lost the even goes from something rather -> empty.

Hence the ARG1='' ARG2='*' for start; and ARG1='*' ARG2='' for stop.

Revision history for this message
Iain Lane (laney) wrote :

On Wed, Sep 02, 2015 at 10:11:47AM -0000, Dimitri John Ledkov wrote:
> @Laney and what is https://code.launchpad.net/~xnox/nuntium/drop-sys-events/+merge/246049 ?
>
> Please merge this already........ somehow..... it's been 8 months now.

Thanks :)

I asked abeato if he would review that.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Iain Lane (laney) wrote :

https://code.launchpad.net/~alfonsosanchezbeato/nuntium/drop-sys-events/+merge/269901

Done!

Unmerged revisions

19. By Dimitri John Ledkov

Migrate from :sys:started events to dbus owner signals. (LP:
#1409356)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches