Ubuntu Terminal App

Merge lp://staging/~xnox/ubuntu-terminal-app/merge-plugin+lxml+py3 into lp://staging/~dpm/ubuntu-terminal-app/merge-plugin

  1. merge-plugin+lxml+py3
  2. Merge into merge-plugin
Proposed by Dimitri John Ledkov
Status: Rejected
Rejected by: David Planella
Proposed branch: lp://staging/~xnox/ubuntu-terminal-app/merge-plugin+lxml+py3
Merge into: lp://staging/~dpm/ubuntu-terminal-app/merge-plugin
Diff against target: 59 lines (+4/-10)
4 files modified
README.md (+0/-6)
debian/control (+2/-2)
tests/autopilot/CMakeLists.txt (+1/-1)
tests/autopilot/ubuntu_terminal_app/CMakePluginParser.py (+1/-1)
To merge this branch: bzr merge lp://staging/~xnox/ubuntu-terminal-app/merge-plugin+lxml+py3
Reviewer Review Type Date Requested Status
David Planella Disapprove
Nicholas Skaggs Pending
Review via email: mp+218483@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

install autopilot tests into python3 path.

lp://staging/~xnox/ubuntu-terminal-app/merge-plugin+lxml+py3 updated
73. By Dimitri John Ledkov

Add python3 build-dep.

Revision history for this message
David Planella (dpm) wrote :

Rejected as part of cleaning up MPs for Terminal. We discussed the changes on this branch a while ago (I can't find the comments, though), and the issue is that replacing the Python import without replacing the code that processes the XML won't work.

review: Disapprove
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Apart from "didn't work" comment no other comments were provided neither at
the time, not now. Fully works here for me. What's wrong?
On 12 Aug 2014 15:41, "David Planella" <email address hidden> wrote:

> Review: Disapprove
>
> Rejected as part of cleaning up MPs for Terminal. We discussed the changes
> on this branch a while ago (I can't find the comments, though), and the
> issue is that replacing the Python import without replacing the code that
> processes the XML won't work.
> --
>
> https://code.launchpad.net/~xnox/ubuntu-terminal-app/merge-plugin+lxml+py3/+merge/218483
> You are the owner of lp:~xnox/ubuntu-terminal-app/merge-plugin+lxml+py3.
>

Unmerged revisions

73. By Dimitri John Ledkov

Add python3 build-dep.

72. By Dimitri John Ledkov

Install autopilot tests into python3 path.

71. By Dimitri John Ledkov

Drop lxml dependency

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches