Merge lp://staging/~xnox/ubuntu-archive-tools/no-verifiction-needed into lp://staging/ubuntu-archive-tools

Proposed by Dimitri John Ledkov
Status: Rejected
Rejected by: Steve Langasek
Proposed branch: lp://staging/~xnox/ubuntu-archive-tools/no-verifiction-needed
Merge into: lp://staging/ubuntu-archive-tools
Diff against target: 14 lines (+0/-4)
1 file modified
sru_workflow.py (+0/-4)
To merge this branch: bzr merge lp://staging/~xnox/ubuntu-archive-tools/no-verifiction-needed
Reviewer Review Type Date Requested Status
Brian Murray (community) Needs Information
Steve Langasek Approve
Review via email: mp+369290@code.staging.launchpad.net

Commit message

Stop adding verification-needed tags.

Description of the change

Stop adding verification-needed tags.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

=== modified file 'sru_workflow.py'
--- old/sru_workflow.py 2018-08-31 23:15:18 +0000
+++ new/sru_workflow.py 2019-06-25 12:32:12 +0000
@@ -84,10 +84,6 @@
                 tags.remove(t)
                 bug.tags = tags

- if 'verification-needed' not in btags:
- btags.append('verification-needed')
- bug.tags = btags
-
         needed_tag = 'verification-needed-%s' % release
         if needed_tag not in btags:
             btags.append(needed_tag)

Revision history for this message
Steve Langasek (vorlon) wrote :

I don't see any blockers for this (nothing else in any of the repos I'm looking at requires this tag to exist). But I'd like a second set of eyeballs from the SRU team.

review: Approve
Revision history for this message
Brian Murray (brian-murray) wrote :

The point behind this tag was to provide the Ubuntu SRU Verification team an easy way (with in Launchpad) to find SRU bugs needing verification for every series, rather than needing to use verification-need-$series for multiple series.

Is having this tag in bug reports causing some issues?

review: Needs Information
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Yes, because setting it to verification-done triggers "do not use
verification-done tag message".

This is public facing, and it confuses users to have the extra tag
irrespective of it is of convenience to a very small finate set of Sru team
members.

We also have a small number of active releases we sru for. To search for
those bugs, which are all listed on pending-sru page too.

On Tue, 25 Jun 2019, 16:20 Brian Murray, <email address hidden> wrote:

> Review: Needs Information
>
> The point behind this tag was to provide the Ubuntu SRU Verification team
> an easy way (with in Launchpad) to find SRU bugs needing verification for
> every series, rather than needing to use verification-need-$series for
> multiple series.
>
> Is having this tag in bug reports causing some issues?
> --
>
> https://code.launchpad.net/~xnox/ubuntu-archive-tools/no-verifiction-needed/+merge/369290
> You are the owner of lp:~xnox/ubuntu-archive-tools/no-verifiction-needed.
>

Revision history for this message
Brian Murray (brian-murray) wrote :

The message regarding not using the verification-done tag was setup when we were transitioning to per release tags for verification. Given that this transition happened about two years ago perhaps it would be best to just remove the code that posts this message. This way the Ubuntu SRU Verification team (which is different than the SRU team) can still subscribe to the tag "verification-needed" to be notified of bugs needing verification.

Would that work for you?

review: Needs Information
Revision history for this message
Brian Murray (brian-murray) wrote :

I've gone ahead and removed the code which posts the message regarding not using verification-done since it made sense anyway.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Cool, we can reject this proposal then.

On Wed, 3 Jul 2019, 21:29 Brian Murray, <email address hidden> wrote:

> I've gone ahead and removed the code which posts the message regarding not
> using verification-done since it made sense anyway.
> --
>
> https://code.launchpad.net/~xnox/ubuntu-archive-tools/no-verifiction-needed/+merge/369290
> You are the owner of lp:~xnox/ubuntu-archive-tools/no-verifiction-needed.
>

Unmerged revisions

1223. By Dimitri John Ledkov

Stop adding verification-needed tag.

Especially since flipping it to verification-done causes annoying
nagging comment spam that it should no longer be used.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches