system-service

Merge lp://staging/~xnox/system-service/python3 into lp://staging/system-service

  1. python3
  2. Merge into ubuntu
Proposed by Dimitri John Ledkov
Status: Needs review
Proposed branch: lp://staging/~xnox/system-service/python3
Merge into: lp://staging/system-service
Diff against target: 197 lines (+31/-29)
8 files modified
UbuntuSystemService/backend.py (+7/-10)
UbuntuSystemService/utils.py (+3/-3)
backend/system-service-d (+4/-4)
debian/changelog (+6/-0)
debian/compat (+1/-1)
debian/control (+7/-6)
debian/rules (+1/-1)
setup.py (+2/-4)
To merge this branch: bzr merge lp://staging/~xnox/system-service/python3
Reviewer Review Type Date Requested Status
Martin Pitt Approve
Michael Vogt Pending
Review via email: mp+192805@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Pitt (pitti) wrote :

LGTM, except this bit:

65 - print (model, layout, variant, options)
66 + print((model, layout, variant, options))

which I assume is an overzealous 2to3 artifact. I'll revert that, and otherwise upload. Thanks!

review: Approve
Reply
Revision history for this message
Martin Pitt (pitti) wrote :

Ignore me, it was actually printing a tuple in the 2.x version as well, so this is fine.

Reply
Revision history for this message
Martin Pitt (pitti) wrote :

I tested this with trying to set a proxy in control-center's Network tab, and applying system-wide. This stopped working with this branch.

$ sudo /usr/lib/system-service/system-service-d
Traceback (most recent call last):
  File "/usr/lib/system-service/system-service-d", line 22, in <module>
    from UbuntuSystemService.backend import ServiceBackend
ImportError: No module named UbuntuSystemService.backend

Seems you forgot to update the shebangs?

review: Needs Fixing
Reply
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Yeap, forgot to port the wrapper script that launches the service. Now ported that and checked that it operates without crash / tracebacks.

Reply
Revision history for this message
Martin Pitt (pitti) wrote :

Didn't test again, but this looks good now, thank you!

review: Approve
Reply

Unmerged revisions

76. By Dimitri John Ledkov

Clean-up unused imports

75. By Dimitri John Ledkov

port system-service-d to python3.

74. By Dimitri John Ledkov

Port to python3.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches