goget-ubuntu-touch

Merge lp://staging/~xnox/goget-ubuntu-touch/product-uuid into lp://staging/goget-ubuntu-touch

  1. product-uuid
  2. Merge into trunk
Proposed by Dimitri John Ledkov
Status: Needs review
Proposed branch: lp://staging/~xnox/goget-ubuntu-touch/product-uuid
Merge into: lp://staging/goget-ubuntu-touch
Diff against target: 157 lines (+76/-1)
5 files modified
debian/control (+1/-0)
ubuntu-emulator/create.go (+4/-0)
ubuntu-emulator/diskimage/image.go (+10/-0)
ubuntu-emulator/run.go (+5/-1)
ubuntu-emulator/sysutils/stamp.go (+56/-0)
To merge this branch: bzr merge lp://staging/~xnox/goget-ubuntu-touch/product-uuid
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Brian Murray Approve
PS Jenkins bot continuous-integration Approve
Benjamin Zeller Pending
Review via email: mp+229315@code.staging.launchpad.net

Commit message

Enable unique & persistent whoopsie ids, per ubuntu-emulator instance

Description of the change

Enable unique & persistent whoopsie ids, per ubuntu-emulator instance

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:62
http://jenkins.qa.ubuntu.com/job/goget-ubuntu-touch-ci/61/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/goget-ubuntu-touch-utopic-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/goget-ubuntu-touch-utopic-armhf-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/goget-ubuntu-touch-utopic-i386-ci/25

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/goget-ubuntu-touch-ci/61/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Brian Murray (brian-murray) wrote :

Do these changes allow one to manually set the CRASH_DB_IDENTIFIER? I ask as in bug 1324455 we want to be able to setup CRASH_DB_IDENTIFIER to start with deadbeef for systems under automated testing so that they are not counted in crash counters.

Otherwise this looks okay to me.

Reply
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

On 17 September 2014 20:05, Brian Murray <email address hidden> wrote:
> Do these changes allow one to manually set the CRASH_DB_IDENTIFIER? I ask as in bug 1324455 we want to be able to setup CRASH_DB_IDENTIFIER to start with deadbeef for systems under automated testing so that they are not counted in crash counters.
>

yes.

> Otherwise this looks okay to me.
> --
> https://code.launchpad.net/~xnox/goget-ubuntu-touch/product-uuid/+merge/229315
> You are the owner of lp:~xnox/goget-ubuntu-touch/product-uuid.

--
Regards,

Dimitri.

Reply
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

ping, why was this still not merged?

Reply
Revision history for this message
Brian Murray (brian-murray) :
review: Approve
Reply
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Since we error on not being able to read the uuid, how are we going to communicate in a friendly way that people might need to regen their emulator images?

Reply
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

No, that's not what the logic is.

Check if uuid exist, if not write it out.
Read uuid, return uuid.

Thus if it's non-existant it is created on the fly. Thus there is no regeneration required.

Reply
Revision history for this message
Sergio Schvezov (sergiusens) :
review: Approve
Reply
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

Can you merge trunk?

Reply
Revision history for this message
Brian Murray (brian-murray) wrote :

Is this useful anymore?

Reply

Unmerged revisions

62. By Dimitri John Ledkov

Customize-in whoopsie-id, since !intel does not support dmi/id/product_uuid

61. By Dimitri John Ledkov

Enable product_uuid on ubuntu-emulator.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches