Merge ~xnox/germinate/+git/builtusing2:master into germinate:master

Shall I upload this to the archive? But it would need deployment on snake fruit too...

Note the:
golang-go-xdg: golang-go-xdg-dev
[Reverse-Depends: Rescued from golang-go-xdg (Reverse Built-Using ubuntu-push-client,golang-ubuntu-push-dev)]

in the new html.

Currently it says for this package:
golang-go-xdg: golang-go-xdg-dev
[Reverse-Depends: Rescued from golang-go-xdg]

No other changes to any other logic, just the comment that is pushed out to the .html output has more useful information.

This looks broadly OK, but I've commented on a few things I'd like to see fixed before we land this.

Thank you for this review and comments.

Thinking about this now, I think the most user-friendly result here would be to do the following:

 - inspect built-using
 - if built-using binaries, are in build-deps
 - turn follow-build-depends back on for that build-dep

Plus, all the things you mentioned in your review comments including go and non-go test cases.

> - if built-using binaries, are in build-deps

Built-Using contains sources, not binaries. We don't require build-deps to be in main, and I don't see why binaries of Built-Using should be any more special. We should be concerned with promoting sources here, not binaries.

ie: If I build foo-main against libbaruniverse-static, Canonical is committing to support the baruniverse SOURCE that produced libbaruniverse (to make sure we get it updates with security fixes, etc), and we have to ship it alongside foo for GPL compliance reasons, but that doesn't mean we're saying we support users installing the binary package libuniverse-static.

Trying to guess at binaries seems like a pointless exercise, really, and it's entirely possible to promote a source but none of its binaries.

ok. This makes more sense.

On Fri, 18 Oct 2019 at 17:09, Adam Conrad <adconrad@0c3.net> wrote:
>
> > - if built-using binaries, are in build-deps
>
> Built-Using contains sources, not binaries. We don't require build-deps to be in main, and I don't see why binaries of Built-Using should be any more special. We should be concerned with promoting sources here, not binaries.
>
> ie: If I build foo-main against libbaruniverse-static, Canonical is committing to support the baruniverse SOURCE that produced libbaruniverse (to make sure we get it updates with security fixes, etc), and we have to ship it alongside foo for GPL compliance reasons, but that doesn't mean we're saying we support users installing the binary package libuniverse-static.
>
> Trying to guess at binaries seems like a pointless exercise, really, and it's entirely possible to promote a source but none of its binaries.
> --
> https://code.launchpad.net/~xnox/germinate/+git/builtusing2/+merge/308743
> You are the owner of ~xnox/germinate/+git/builtusing2:master.

--
Regards,

Dimitri.