Merge lp://staging/~xnox/deja-dup/drop-u1 into lp://staging/deja-dup/30
Proposed by
Dimitri John Ledkov
| Status: | Rejected |
|---|---|
| Rejected by: | Michael Terry |
| Proposed branch: | lp://staging/~xnox/deja-dup/drop-u1 |
| Merge into: | lp://staging/deja-dup/30 |
| Diff against target: |
574 lines (+3/-399) 10 files modified
data/org.gnome.DejaDup.gschema.xml.in (+0/-9) deja-dup/deja-dup.appdata.xml.in (+1/-1) deja-dup/widgets/CMakeLists.txt (+0/-1) deja-dup/widgets/ConfigLabelLocation.vala (+0/-2) deja-dup/widgets/ConfigLocation.vala (+0/-16) deja-dup/widgets/ConfigLocationU1.vala (+0/-38) libdeja/Backend.vala (+0/-3) libdeja/BackendAuto.vala (+2/-11) libdeja/BackendU1.vala (+0/-317) libdeja/CMakeLists.txt (+0/-1) |
| To merge this branch: | bzr merge lp://staging/~xnox/deja-dup/drop-u1 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Terry | Disapprove | ||
|
Review via email:
|
|||
Commit message
Drop U1 backend.
Description of the change
Drop U1 backend.
To post a comment you must log in.
Unmerged revisions
- 1532. By Dimitri John Ledkov
-
Drop U1 backend.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Mostly good. But rather than deleting the settings and widgets for U1, I'd like to keep them intact but as skeletons of their former selves, just there to show error messages or some such about U1 being removed.
With this branch as is, a user upgrading will automatically have their settings changed for them. That's a bad experience.
I'm working on the changes necessary.