debian-installer

Merge lp://staging/~xnox/debian-installer/deprecated-ubuntu into lp://staging/~ubuntu-core-dev/debian-installer/ubuntu

  1. deprecated-ubuntu
  2. Merge into ubuntu
Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 2367
Proposed branch: lp://staging/~xnox/debian-installer/deprecated-ubuntu
Merge into: lp://staging/~ubuntu-core-dev/debian-installer/ubuntu
Diff against target: 181 lines (+140/-1) (has conflicts)
4 files modified
debian/FOOTER.html (+25/-0)
debian/HEADER.html (+103/-0)
debian/changelog (+10/-0)
debian/rules (+2/-1)
Text conflict in debian/changelog
To merge this branch: bzr merge lp://staging/~xnox/debian-installer/deprecated-ubuntu
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Paride Legovini Approve
Ubuntu Core Development Team Pending
Review via email: mp+381214@code.staging.launchpad.net

Commit message

This changes all d-i urls from /images/ to /deprecated-images/

Also it adds a nice HEADER.html/FOOTER.html to celebrate the new Ubuntu Server Installer

I uploaded example into my PPA and it looks like this:

http://ppa.launchpad.net/xnox/nonvirt/ubuntu/dists/focal/main/installer-amd64/current/deprecated-images/

To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote :

Hi Dimitri,

Should the content of FOOTER.html show up in the example page you prepared? It seems it does not.

review: Needs Information
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

@paride well spotted, whilst it is correct it seems like apache is missconfigured. Also footer is not getting shown on cdimage.ubuntu.com either

I will open separate bugs about that.

The expectation was for footer to look like it does on http://releases.ubuntu.com/bionic/

And broken behaviour is visible on the my ppa sample and on http://cdimage.ubuntu.com/daily-live/pending/

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Opened https://bugs.launchpad.net/ubuntu/+bug/1869218 for the FOOTER.html not getting rendered.

Revision history for this message
Paride Legovini (paride) wrote :

In general looks good. I would add a

<h2>Deprecated images</h2>

header right before the "The deprecated Ubuntu Installer is still available below ..." paragraph. In its current form the file list appears to be under the "Try the New Ubuntu Installer" section, and at first glance this could wrongly suggest that the files below *are* the New Ubuntu Installer.

Revision history for this message
Paride Legovini (paride) wrote :

If we want to keep all those pages with a single <h2> section (reasonable), then I'd still change it to:

<h2>Deprecated images</h2>

for clarity.

lp://staging/~xnox/debian-installer/deprecated-ubuntu updated
2367. By Dimitri John Ledkov

Clarify headers in the HEADER.html

Revision history for this message
Paride Legovini (paride) wrote :

LGTM

review: Approve
lp://staging/~xnox/debian-installer/deprecated-ubuntu updated
2368. By Dimitri John Ledkov

Move warning that no updates will be made, to the second heading

Revision history for this message
Paride Legovini (paride) wrote :

+1

review: Approve
lp://staging/~xnox/debian-installer/deprecated-ubuntu updated
2369. By Dimitri John Ledkov

Use Classic name

Revision history for this message
Steve Langasek (vorlon) wrote :

+1, modulo the merge conflict.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches