curtin

Merge ~xnox/curtin:rocky into curtin:master

Git
lp:~xnox/curtin
rocky
Merge into master

Proposed by Dimitri John Ledkov on 2022-02-15

Status:

Merged

Approved by:

Dan Bungert on 2022-02-15

Approved revision:

9ef03d7f83de26f4c130df4a7d741b27375e01fc

Merge reported by:

Server Team CI bot

Merged at revision:

not available

Proposed branch:

~xnox/curtin:rocky

Merge into:

curtin:master

Diff against target:

36 lines (+4/-3)

2 files modified

curtin/distro.py (+3/-2)
pylintrc (+1/-1)

Undecided

Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
Dan Bungert		2022-02-15	Approve on 2022-02-15
Server Team CI bot	continuous-integration		Approve on 2022-02-15
Review via email: mp+415604@code.staging.launchpad.net

Commit message

Add rocky linux as a RHEL-like variant

Revision history for this message

Dimitri John Ledkov (xnox) wrote on 2022-02-15:

Entirely untested, and coded based on inspecting RPMs empirically.

Revision history for this message

Server Team CI bot (server-team-bot) wrote on 2022-02-15:

FAILED: Continuous integration, rev:a3a4cdfd868774248e853be6e96e2549d13736b8
https://jenkins.ubuntu.com/server/job/curtin-ci/237/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/237/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/237/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/237/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/237/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/237//rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Server Team CI bot (server-team-bot) wrote on 2022-02-15:

FAILED: Continuous integration, rev:0750f8fc734a88199cf4000d43ee165e8d209660
https://jenkins.ubuntu.com/server/job/curtin-ci/238/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/238/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/238/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/238/
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/238/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/238//rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Server Team CI bot (server-team-bot) wrote on 2022-02-15:

PASSED: Continuous integration, rev:9ef03d7f83de26f4c130df4a7d741b27375e01fc
https://jenkins.ubuntu.com/server/job/curtin-ci/239/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/239/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/239/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/239/
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/239/

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/239//rebuild

review: Approve (continuous-integration)

Revision history for this message

Francesco Santagata (phrancesco) wrote on 2022-02-15:

Hi,

I patched distro.py inside this one curtin package:

https://launchpad.net/~dbungert/+archive/ubuntu/curtin-lp-1955671

It's working.

I tested on two VMs (1 Bios + 1 UEFI).

With this "https://launchpad.net/~dbungert/+archive/ubuntu/curtin-lp-1955671"
BIOS Centos 8.4 OK, Rocky 8.4 OK
UEFI Centos 8.4 OK, Rocky 8.4 KO

With your latest patch of distro.py Rocky 8.4 on UEFI is working.

Minor Issue, at boot time it tests a lot of efi files before finding the right one...
The first time is really slow, then the "scan" goes much faster.

I have a screen capture of it.

BR
Francesco

PS
please let me know if you need a more clean test... got some problems with "git+ssh" a lost a little bit of focus.

Revision history for this message

Dan Bungert (dbungert) wrote on 2022-02-15:

Thanks Dimitri!
Tested by Francesco as mentioned on linked bug.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.