Merge lp://staging/~xnox/charms/precise/sbuild/add-more-options into lp://staging/charms/sbuild

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 5
Proposed branch: lp://staging/~xnox/charms/precise/sbuild/add-more-options
Merge into: lp://staging/charms/sbuild
Diff against target: 157 lines (+51/-19)
4 files modified
config.yaml (+16/-0)
hooks/config-changed (+17/-3)
hooks/install (+17/-15)
revision (+1/-1)
To merge this branch: bzr merge lp://staging/~xnox/charms/precise/sbuild/add-more-options
Reviewer Review Type Date Requested Status
Juan L. Negron (community) Approve
Review via email: mp+135099@code.staging.launchpad.net

Description of the change

  * make btsparty an option (to have unattended sbuilds)
  * add $HOME option (set to /mnt, as that's where most clouds give space)
  * add .mk-sbuild.rc & .mk-sbuild.sources (for mk-sbuild integration)

To post a comment you must log in.
Revision history for this message
Juan L. Negron (negronjl) wrote :

Hi Dmitrijs:

Thank you for the extra options in the charm.

This looks good to me and, it doesn't seem to be breaking anything.

Approved.

Merged.

Thanks,

Juan

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: