autopkgtest-cloud

Merge ~xnox/autopkgtest-cloud/+git/autopkgtest-package-configs:never-run-eol-kernels into ~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-package-configs:main

  1. Git
  2. lp:~xnox/autopkgtest-cloud/+git/autopkgtest-package-configs
  3. never-run-eol-kernels
  4. Merge into main
Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: d50dbfca09be67a8b5046d2362d7347087001348
Proposed branch: ~xnox/autopkgtest-cloud/+git/autopkgtest-package-configs:never-run-eol-kernels
Merge into: ~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-package-configs:main
Diff against target: 64 lines (+56/-0)
1 file modified
never_run (+56/-0)
Reviewer Review Type Date Requested Status
Brian Murray Needs Information
Review via email: mp+432970@code.staging.launchpad.net

Commit message

Add EOL kernels to never_run

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I'm pretty sure all doesn't work in the never run file. Did you do any investigation to see if it does?

review: Needs Information
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

> I'm pretty sure all doesn't work in the never run file. Did you do any
> investigation to see if it does?

def request_matches_per_package(package, arch, release, s):
    return (any(fnmatch.fnmatchcase(f"{package}/{arch}/{release}", entry) for entry in s) or
            any(fnmatch.fnmatchcase(f"{package}/{arch}/all", entry) for entry in s) or
            any(fnmatch.fnmatchcase(f"{package}/all/all", entry) for entry in s))

It seems correct that one can match on "all" releases, and all arches & all releases, but not on all arches with specific release.

Should we add support for

            any(fnmatch.fnmatchcase(f"{package}/all/{release}", entry) for entry in s) or

It seems like that would collapse a few existing never_run hints as well.

Revision history for this message
Brian Murray (brian-murray) wrote :

Yes, adding support for that makes sense to me and would help with adding packages from debian's reject_list to our never_run list.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

> Yes, adding support for that makes sense to me and would help with adding
> packages from debian's reject_list to our never_run list.

https://code.launchpad.net/~xnox/autopkgtest-cloud/+git/autopkgtest-cloud/+merge/433133

making it so

Revision history for this message
Paride Legovini (paride) wrote :

autopkgtest-cloud MP merged, but the change will require a charm update to go live.

Revision history for this message
Brian Murray (brian-murray) wrote :

Out of an abundance of caution we should probably hold off on merging this until after the charm update has landed.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches