Juju Charms Collection
ceph package

Merge lp://staging/~xfactor973/charms/trusty/ceph/bug_1513009 into lp://staging/~openstack-charmers-archive/charms/trusty/ceph/next

  1. Trusty Tahr (14.04)
  2. bug_1513009
  3. Merge into next
Proposed by Chris Holcombe
Status: Work in progress
Proposed branch: lp://staging/~xfactor973/charms/trusty/ceph/bug_1513009
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/ceph/next
Diff against target: 201 lines (+118/-5)
4 files modified
.bzrignore (+1/-0)
charm-helpers-hooks.yaml (+1/-0)
hooks/ceph.py (+11/-5)
hooks/charmhelpers/contrib/storage/linux/lvm.py (+105/-0)
To merge this branch: bzr merge lp://staging/~xfactor973/charms/trusty/ceph/bug_1513009
Reviewer Review Type Date Requested Status
James Page Needs Fixing
Billy Olsen Pending
Review via email: mp+284989@code.staging.launchpad.net

Description of the change

This change handles the case of LVM PV disks being handed to Ceph. Basically this is a 3 liner + pulling in the LVM code from charmhelpers.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #124 ceph-next for xfactor973 mp284989
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/124/

Reply
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #134 ceph-next for xfactor973 mp284989
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/134/

Reply
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #19 ceph-next for xfactor973 mp284989
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15003597/
Build: http://10.245.162.36:8080/job/charm_amulet_test/19/

Reply
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #32 ceph-next for xfactor973 mp284989
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15009723/
Build: http://10.245.162.36:8080/job/charm_amulet_test/32/

Reply
Revision history for this message
James Page (james-page) wrote :

Re-running amulet tests...

Reply
Revision history for this message
James Page (james-page) wrote :

Check needs to go a bit deeper - see inline comment

review: Needs Fixing
Reply
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #95 ceph-next for xfactor973 mp284989
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15016032/
Build: http://10.245.162.36:8080/job/charm_amulet_test/95/

Reply

Unmerged revisions

126. By Chris Holcombe

Merge upstream

125. By Chris Holcombe

Check for lvm pvs

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches