Ubuntu
cheese package

Merge lp://staging/~xerosis/ubuntu/oneiric/cheese/cheese-fix-for-817806 into lp://staging/ubuntu/oneiric/cheese

  1. Oneiric (11.10)
  2. cheese-fix-for-817806
  3. Merge into oneiric
Proposed by Kieran Hogg
Status: Merged
Merged at revision: 64
Proposed branch: lp://staging/~xerosis/ubuntu/oneiric/cheese/cheese-fix-for-817806
Merge into: lp://staging/ubuntu/oneiric/cheese
Diff against target: 30 lines (+9/-2)
2 files modified
debian/changelog (+6/-0)
src/cheese-window.vala (+3/-2)
To merge this branch: bzr merge lp://staging/~xerosis/ubuntu/oneiric/cheese/cheese-fix-for-817806
Reviewer Review Type Date Requested Status
Paolo Rotolo (community) Needs Fixing
Brian Murray Approve
Ubuntu branches Pending
Review via email: mp+72246@code.staging.launchpad.net

Description of the change

Fix for bug #817806 CHeese crashes when clicking the Effects button, patch taken from https://bugzilla.gnome.org/show_bug.cgi?id=647677

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

This looks good to me and I'm testing it now. Thanks for helping out!

review: Approve
Revision history for this message
Brian Murray (brian-murray) wrote :

Hrm I've run into some build failures with cheese:

/usr/bin/valac --thread --vapidir vapi --pkg config --pkg gtk+-3.0 --pkg gmodule-2.0 --pkg gee-1.0 --pkg clutter-1.0 --pkg clutter-gtk-1.0 --pkg gstreamer-0.10 --pkg libcanberra-gtk --pkg libcanberra --pkg eogthumbnav --pkg cheese-thumbview --pkg cheese-common --pkg clutter-tablelayout -C cheese-main.vala cheese-window.vala cheese-countdown.vala cheese-effects-manager.vala cheese-preferences.vala thumbview/cheese-thumb-view.c thumbview/cheese-thumbnail.c thumbview/eog-thumb-nav.c
error: Package `config' not found in specified Vala API directories or GObject-Introspection GIR directories
error: Package `eogthumbnav' not found in specified Vala API directories or GObject-Introspection GIR directories
error: Package `cheese-thumbview' not found in specified Vala API directories or GObject-Introspection GIR directories
error: Package `cheese-common' not found in specified Vala API directories or GObject-Introspection GIR directories
error: Package `clutter-tablelayout' not found in specified Vala API directories or GObject-Introspection GIR directories

Revision history for this message
Paolo Rotolo (paolorotolo) wrote :

Hi,
I have tested this... All good in compilation, but this version don't resolve the bug...
Cheese crashes again when clicking the effects button...

Bye :)

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: