Merge lp://staging/~xavpaice/landscape-client-charm/lp1825267 into lp://staging/landscape-client-charm

Proposed by Xav Paice
Status: Rejected
Rejected by: Haw Loeung
Proposed branch: lp://staging/~xavpaice/landscape-client-charm/lp1825267
Merge into: lp://staging/landscape-client-charm
Diff against target: 2620 lines (+1684/-161)
24 files modified
Makefile (+1/-2)
hooks/charmhelpers/__init__.py (+65/-4)
hooks/charmhelpers/core/hookenv.py (+450/-28)
hooks/charmhelpers/core/host.py (+170/-11)
hooks/charmhelpers/core/host_factory/centos.py (+16/-0)
hooks/charmhelpers/core/host_factory/ubuntu.py (+58/-0)
hooks/charmhelpers/core/kernel.py (+2/-2)
hooks/charmhelpers/core/services/base.py (+18/-7)
hooks/charmhelpers/core/strutils.py (+64/-5)
hooks/charmhelpers/core/sysctl.py (+21/-10)
hooks/charmhelpers/core/templating.py (+18/-9)
hooks/charmhelpers/core/unitdata.py (+8/-1)
hooks/charmhelpers/fetch/__init__.py (+19/-9)
hooks/charmhelpers/fetch/archiveurl.py (+1/-1)
hooks/charmhelpers/fetch/bzrurl.py (+2/-2)
hooks/charmhelpers/fetch/centos.py (+1/-1)
hooks/charmhelpers/fetch/giturl.py (+2/-2)
hooks/charmhelpers/fetch/python/__init__.py (+13/-0)
hooks/charmhelpers/fetch/python/debug.py (+54/-0)
hooks/charmhelpers/fetch/python/packages.py (+154/-0)
hooks/charmhelpers/fetch/python/rpdb.py (+56/-0)
hooks/charmhelpers/fetch/python/version.py (+32/-0)
hooks/charmhelpers/fetch/snap.py (+33/-5)
hooks/charmhelpers/fetch/ubuntu.py (+426/-62)
To merge this branch: bzr merge lp://staging/~xavpaice/landscape-client-charm/lp1825267
Reviewer Review Type Date Requested Status
Xav Paice (community) Needs Resubmitting
🤖 Landscape Builder test results Approve
Landscape Pending
Review via email: mp+366238@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Fail
Revno: 69
Branch: lp:~xavpaice/landscape-client-charm/lp1825267
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3926/

review: Needs Fixing (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Fail
Revno: 69
Branch: lp:~xavpaice/landscape-client-charm/lp1825267
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3928/

review: Needs Fixing (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 69
Branch: lp:~xavpaice/landscape-client-charm/lp1825267
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3931/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 69
Branch: lp:~xavpaice/landscape-client-charm/lp1825267
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3933/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Fail
Revno: 69
Branch: lp:~xavpaice/landscape-client-charm/lp1825267
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3936/

review: Needs Fixing (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 69
Branch: lp:~xavpaice/landscape-client-charm/lp1825267
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3939/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 69
Branch: lp:~xavpaice/landscape-client-charm/lp1825267
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3948/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 69
Branch: lp:~xavpaice/landscape-client-charm/lp1825267
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3959/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 69
Branch: lp:~xavpaice/landscape-client-charm/lp1825267
Jenkins: https://ci.lscape.net/job/latch-test-xenial/3964/

review: Approve (test results)
Revision history for this message
Xav Paice (xavpaice) wrote :

if this is still relevant it needs some serious rebase and retesting

review: Needs Resubmitting

Unmerged revisions

69. By Xav Paice

Update charmhelpers and Makefile

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: