Prometheus2 charm

Merge ~xavpaice/charm-prometheus2:lp1947913 into charm-prometheus2:master

  1. Git
  2. lp:~xavpaice/charm-prometheus2
  3. lp1947913
  4. Merge into master
Proposed by Xav Paice
Status: Rejected
Rejected by: Haw Loeung
Proposed branch: ~xavpaice/charm-prometheus2:lp1947913
Merge into: charm-prometheus2:master
Diff against target: 61 lines (+15/-4)
4 files modified
src/metadata.yaml (+3/-3)
src/reactive/prometheus.py (+1/-1)
src/tests/functional/requirements.txt (+1/-0)
src/tox.ini (+10/-0)
Reviewer Review Type Date Requested Status
🤖 prod-jenkaas-bootstack continuous-integration Needs Fixing
Andrea Ieri Approve
BootStack Reviewers mr tracking; do not claim Pending
BootStack Reviewers Pending
Review via email: mp+410563@code.staging.launchpad.net

Commit message

Update snap resources for core20

The prometheus snap no longer uses the 'core' snap, but 'core20'. Update the resources defined, and snap installation, to reflect that change.

Closes-bug: LP: #1947913

To post a comment you must log in.
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Andrea Ieri (aieri) wrote :

lgtm

review: Approve
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:ac867f98def685945ce236fe382426b80fe1804c
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus2-ci/9/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/171/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/602/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus2-ci/9//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

A CI job is currently in progress. A follow up comment will be added when it completes.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:8f75b70cc97585d0e2ba2f1d0b6b16cd47b8e968
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus2-ci/10/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/172/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/605/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus2-ci/10//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:8f75b70cc97585d0e2ba2f1d0b6b16cd47b8e968
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus2-ci/11/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/173/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/609/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus2-ci/11//rebuild

review: Needs Fixing (continuous-integration)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: