Merge ~xavpaice/charm-prometheus-openstack-exporter:add_prometheus_rules_relation into charm-prometheus-openstack-exporter:master
Proposed by
Xav Paice
| Status: | Merged |
|---|---|
| Approved by: | Jeremy Lounder |
| Approved revision: | 30fa9bcf9741cf1787473c2fdbd12731b3d9dd0d |
| Merged at revision: | 30fa9bcf9741cf1787473c2fdbd12731b3d9dd0d |
| Proposed branch: | ~xavpaice/charm-prometheus-openstack-exporter:add_prometheus_rules_relation |
| Merge into: | charm-prometheus-openstack-exporter:master |
| Diff against target: |
177 lines (+92/-1) 9 files modified
.gitignore (+11/-0) Makefile (+3/-0) config.yaml (+12/-0) layer.yaml (+1/-0) metadata.yaml (+3/-1) reactive/openstack_exporter.py (+24/-0) templates/rule_schedulable_instances.j2 (+11/-0) unit_tests/rule_schedulable_instances (+10/-0) unit_tests/test_reactive_openstack_exporter.py (+17/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jeremy Lounder (community) | Approve | ||
| Wouter van Bommel (community) | Approve | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Adam Dyess (addyess) wrote | # |
Revision history for this message
| Xav Paice (xavpaice) wrote | # |
Revision history for this message
| Jeremy Lounder (jldev) | # |
review:
Approve
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
unit tests? functional tests?