Merge ~xavpaice/charm-prometheus-openstack-exporter:nrpe-extra-args into ~prometheus-charmers/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:master

Proposed by Xav Paice
Status: Merged
Approved by: Alexandre Gomes
Approved revision: 46cf917a40740d36f40a61ff684dc248a88e6c5a
Merged at revision: eda95420b14d30ceca7df3b67e2b277442005120
Proposed branch: ~xavpaice/charm-prometheus-openstack-exporter:nrpe-extra-args
Merge into: ~prometheus-charmers/charm-prometheus-openstack-exporter/+git/prometheus-openstack-exporter-charm:master
Diff against target: 30 lines (+9/-1)
2 files modified
config.yaml (+6/-0)
reactive/openstack_exporter.py (+3/-1)
Reviewer Review Type Date Requested Status
Alexandre Gomes Approve
Drew Freiberger (community) Approve
Review via email: mp+356449@code.staging.launchpad.net

Commit message

Add extra-nrpe-args config item

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Drew Freiberger (afreiberger) wrote :

lgtm

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change must be approved by a member of one of the following teams:
 - canonical-sysadmins
Setting status to needs review.

Revision history for this message
Alexandre Gomes (alejdg) wrote :

+1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision eda95420b14d30ceca7df3b67e2b277442005120

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: