hw-health-charm

Merge ~xavpaice/charm-hw-health:fix_tests into ~nagios-charmers/charm-hw-health:master

  1. Git
  2. lp:~xavpaice/charm-hw-health
  3. fix_tests
  4. Merge into master
Proposed by Xav Paice
Status: Superseded
Proposed branch: ~xavpaice/charm-hw-health:fix_tests
Merge into: ~nagios-charmers/charm-hw-health:master
Diff against target: 75 lines (+6/-8)
6 files modified
Makefile (+2/-1)
src/__init__.py (+0/-0)
src/actions/actions.py (+2/-5)
src/tests/__init__.py (+0/-0)
src/tests/unit/test_actions.py (+1/-1)
src/tox.ini (+1/-1)
Reviewer Review Type Date Requested Status
Peter Sabaini Needs Fixing
Review via email: mp+363758@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2019-02-28.

To post a comment you must log in.
Revision history for this message
Peter Sabaini (peter-sabaini) wrote :

Hey, some inline comments

review: Needs Fixing
Revision history for this message
Peter Sabaini (peter-sabaini) wrote :

Um, for tox.ini better

commands = flake8 {posargs} --max-complexity=20 --max-line-length=120 reactive files unit_tests
+commands = flake8 {posargs} --max-complexity=20 --max-line-length=120 .

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches