The Sound Menu

Merge lp://staging/~xavi-garcia-mena/indicator-sound/next-play-prev-buttons-bug-1373313 into lp://staging/indicator-sound/15.04

  1. next-play-prev-buttons-bug-1373313
  2. Merge into trunk.15.04
Proposed by Xavi Garcia
Status: Merged
Approved by: Xavi Garcia
Approved revision: 507
Merged at revision: 497
Proposed branch: lp://staging/~xavi-garcia-mena/indicator-sound/next-play-prev-buttons-bug-1373313
Merge into: lp://staging/indicator-sound/15.04
Prerequisite: lp://staging/~xavi-garcia-mena/indicator-sound/sync-vivid-wily
Diff against target: 488 lines (+269/-85)
7 files modified
debian/changelog (+18/-0)
src/media-player-mpris.vala (+22/-0)
src/media-player.vala (+4/-0)
src/mpris2-interfaces.vala (+4/-1)
src/sound-menu.vala (+61/-6)
tests/media-player-mock.vala (+6/-0)
tests/sound-menu.cc (+154/-78)
To merge this branch: bzr merge lp://staging/~xavi-garcia-mena/indicator-sound/next-play-prev-buttons-bug-1373313
Reviewer Review Type Date Requested Status
Xavi Garcia Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+273234@code.staging.launchpad.net

Commit message

Synchronize the state of the Previous/Play/Next buttons with the state obtained from MPRIS.

The state is updated every time the properties are modified.

Description of the change

Synchronize the state of the Previous/Play/Next buttons with the state obtained from MPRIS.

The state is updated every time the properties are modified.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:507
http://jenkins.qa.ubuntu.com/job/indicator-sound-15.04-ci/2/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-15.04-vivid-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-15.04-vivid-armhf-ci/2
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-15.04-vivid-armhf-ci/2/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-15.04-ci/2/rebuild

review: Approve (continuous-integration)
Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

Approving as this code change was already reviewed and approved by Charles.
This MP is only for vivid.

review: Approve
lp://staging/~xavi-garcia-mena/indicator-sound/next-play-prev-buttons-bug-1373313 updated
508. By Xavi Garcia

Fixed version in changelog

509. By Xavi Garcia

Updating MPRIS control in the menu not only when next and previous are updated

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches