The Sound Menu

Merge lp://staging/~xavi-garcia-mena/indicator-sound/bluetooth-icons-bug-1415480 into lp://staging/indicator-sound/15.10

  1. bluetooth-icons-bug-1415480
  2. Merge into trunk.15.10
Proposed by Xavi Garcia
Status: Merged
Approved by: Charles Kerr
Approved revision: 510
Merged at revision: 508
Proposed branch: lp://staging/~xavi-garcia-mena/indicator-sound/bluetooth-icons-bug-1415480
Merge into: lp://staging/indicator-sound/15.10
Diff against target: 614 lines (+437/-40)
6 files modified
src/CMakeLists.txt (+1/-0)
src/service.vala (+329/-27)
src/sound-menu.vala (+23/-0)
src/volume-control-pulse.vala (+69/-12)
src/volume-control.vala (+14/-0)
tests/notifications-test.cc (+1/-1)
To merge this branch: bzr merge lp://staging/~xavi-garcia-mena/indicator-sound/bluetooth-icons-bug-1415480
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+272735@code.staging.launchpad.net

Commit message

Added the code to change the icons and label when a bluetooth headset is connected

Description of the change

Added the code to change the icons and label when a bluetooth headset is connected

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:506
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/257/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/33
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/33/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/257/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

So many possible states!

Writing coverage test for this will be fun... :-)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:507
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/258/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-amd64-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/34
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/34/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/258/rebuild

review: Approve (continuous-integration)
lp://staging/~xavi-garcia-mena/indicator-sound/bluetooth-icons-bug-1415480 updated
508. By Xavi Garcia

Updated to show a label stating the active output

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:508
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/261/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/37
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/37/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/261/rebuild

review: Approve (continuous-integration)
lp://staging/~xavi-garcia-mena/indicator-sound/bluetooth-icons-bug-1415480 updated
509. By Xavi Garcia

Added USB and HDMI active outputs

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:509
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/262/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-amd64-ci/38
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/38
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/38/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/262/rebuild

review: Approve (continuous-integration)
lp://staging/~xavi-garcia-mena/indicator-sound/bluetooth-icons-bug-1415480 updated
510. By Xavi Garcia

fixed panel root panel icons

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:510
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/263/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-amd64-ci/39
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/39
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-wily-armhf-ci/39/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/263/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

that seems to have broken unity7 notifications (when scrolling over the indicator)

Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

As discussed with Lars Uebernickel, a fix for unity7 is ready to go.
This branch adds a new string to the notification.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches