Merge lp://staging/~xavi-garcia-mena/go-unityscopes/version-rtm-compatibility into lp://staging/go-unityscopes/v1

Proposed by Xavi Garcia
Status: Merged
Approved by: James Henstridge
Approved revision: 62
Merged at revision: 59
Proposed branch: lp://staging/~xavi-garcia-mena/go-unityscopes/version-rtm-compatibility
Merge into: lp://staging/go-unityscopes/v1
Diff against target: 67 lines (+17/-3)
3 files modified
reply.cpp (+8/-0)
tests/goscope/goscope.go (+6/-0)
version.h (+3/-3)
To merge this branch: bzr merge lp://staging/~xavi-garcia-mena/go-unityscopes/version-rtm-compatibility
Reviewer Review Type Date Requested Status
James Henstridge Approve
Review via email: mp+253650@code.staging.launchpad.net

Description of the change

Adding backward compatibility for RTM version of libunity-scopes.
It shows a warning to make the user aware that the PushFilters feature is only available from version 0.6.10.

To post a comment you must log in.
Revision history for this message
James Henstridge (jamesh) :
review: Needs Fixing
59. By Xavi Garcia

Added suggested changes

Revision history for this message
James Henstridge (jamesh) :
review: Needs Fixing
60. By Xavi Garcia

Added suggested changes

Revision history for this message
James Henstridge (jamesh) :
61. By Xavi Garcia

Modified static_assert as it was not correct

62. By Xavi Garcia

Fixed incomtible feature message again

Revision history for this message
James Henstridge (jamesh) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: