Merge lp://staging/~xavi-garcia-mena/go-unityscopes/replies-interfaces into lp://staging/go-unityscopes/v2
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~xavi-garcia-mena/go-unityscopes/replies-interfaces |
| Merge into: | lp://staging/go-unityscopes/v2 |
| Prerequisite: | lp://staging/~xavi-garcia-mena/go-unityscopes/go-subsearch |
| Diff against target: |
640 lines (+198/-168) 6 files modified
reply.go (+106/-78) tests/aggregated/aggregated.go (+71/-72) tests/goscope/goscope.go (+6/-6) tests/simple-scope-2/simple-scope-2.go (+3/-3) tests/simple-scope/simple-scope.go (+3/-3) unityscope.go (+9/-6) |
| To merge this branch: | bzr merge lp://staging/~xavi-garcia-mena/go-unityscopes/replies-interfaces |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Kyle Fazzari (community) | Approve | ||
| James Henstridge | Pending | ||
|
Review via email:
|
|||
Commit message
Moved SearchReply and PreviewReply to be interfaces to make it possible to mock them.
Description of the change
Moved SearchReply and PreviewReply to be interfaces to make it possible to mock them.
| Xavi Garcia (xavi-garcia-mena) wrote | # |
Unmerged revisions
- 84. By Xavi Garcia
-
Moved PreviewReply and SearchReply to be interfaces and make it possible to be mocked
- 83. By Xavi Garcia
-
Added Finished method to SearchListener. Some functions moved from goscope.go to reply.go.
- 82. By Xavi Garcia
-
Removed SetSearchReply and GetSearchReply from the subsearch listener, as they are no longer needed
- 81. By Xavi Garcia
-
Moved subsearch method to SeachReply. Working version
- 80. By Xavi Garcia
-
Moved Subsearch to SearchReply. Passed go fmt to the test files. NOTE: This branch is still work in progress, it's not fully functional
- 79. By Xavi Garcia
-
Removed binary
- 78. By Xavi Garcia
-
Hide wait mechanism for child scopes to the developer. Now Aggregated scopes wait by default transparently
- 77. By Xavi Garcia
-
Removed some comments
- 76. By Xavi Garcia
-
Fixed typo and removed commented include
- 75. By Xavi Garcia
-
Added Subsearch method to retrieve results from child scopes. Added scope-harness tests for aggregated scopes
This is looking good! I have one concern about the SearchReply interface (comments inline). Also, will this require an API version number change (i.e. v3) due to the changes in unityscope.go?