Merge lp://staging/~xapantu/switchboard/fix-selection into lp://staging/~elementary-pantheon/switchboard/switchboard
Proposed by
xapantu
| Status: | Merged |
|---|---|
| Approved by: | Raphael Isemann |
| Approved revision: | 480 |
| Merged at revision: | 479 |
| Proposed branch: | lp://staging/~xapantu/switchboard/fix-selection |
| Merge into: | lp://staging/~elementary-pantheon/switchboard/switchboard |
| Diff against target: |
50 lines (+10/-12) 1 file modified
src/CategoryView.vala (+10/-12) |
| To merge this branch: | bzr merge lp://staging/~xapantu/switchboard/fix-selection |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Raphael Isemann (community) | functionality, code-style | Approve | |
|
Review via email:
|
|||
Commit message
Fixed a bug: Long clicking plugs would enter the plug and then allow the plug to handle the signal too.
To post a comment you must log in.
Revision history for this message
| Raphael Isemann (teemperor) wrote | # |
review:
Approve
(functionality, code-style)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Works, no regressions with the other plugs. It also resolved the ugly fact that just holding a button enters a plug which wasn't fitting with the behaviour of a normal button for example.