Merge lp://staging/~xapantu/granite/fix-955421 into lp://staging/~elementary-pantheon/granite/granite
Proposed by
xapantu
| Status: | Merged |
|---|---|
| Approved by: | Victor Martinez |
| Approved revision: | 203 |
| Merged at revision: | 217 |
| Proposed branch: | lp://staging/~xapantu/granite/fix-955421 |
| Merge into: | lp://staging/~elementary-pantheon/granite/granite |
| Diff against target: |
145 lines (+55/-35) 1 file modified
lib/Widgets/DynamicNotebook.vala (+55/-35) |
| To merge this branch: | bzr merge lp://staging/~xapantu/granite/fix-955421 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Victor Martinez (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fix bug #955421
To post a comment you must log in.
Revision history for this message
| Victor Martinez (victored) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hey Lucas, I tested this a while ago but forgot to mention that after you've closed all the tabs, creating a new tab results in a segfault. The origin is here:
tabs.switch_
page = tabs.tabs.index_of (t); // Segfault point.
});
Apart from that, this indeed fixes Bug #955421, so this could be merged into trunk. Maybe the problem I describe should be threated as a separate issue/report?