Merge lp://staging/~xaav/loggerhead/export-tarball into lp://staging/loggerhead
Proposed by
xaav
Status: | Superseded |
---|---|
Proposed branch: | lp://staging/~xaav/loggerhead/export-tarball |
Merge into: | lp://staging/loggerhead |
Diff against target: |
242 lines (+81/-6) 9 files modified
.bzrignore (+1/-0) loggerhead/apps/branch.py (+9/-3) loggerhead/config.py (+3/-0) loggerhead/controllers/__init__.py (+1/-1) loggerhead/controllers/download_ui.py (+18/-0) loggerhead/controllers/revision_ui.py (+2/-1) loggerhead/exporter.py (+40/-0) loggerhead/history.py (+3/-0) loggerhead/templates/revision.pt (+4/-1) |
To merge this branch: | bzr merge lp://staging/~xaav/loggerhead/export-tarball |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins | Needs Fixing | ||
Martin Albisetti | Pending | ||
Review via email: mp+62941@code.staging.launchpad.net |
This proposal has been superseded by a proposal from 2011-06-08.
Description of the change
This branch **may** accomplish exporting the tarball using chunked transfer encoding. The code all looks to be correct, but I have not tested it, so I would like your opinion.
Thanks!
To post a comment you must log in.
Thanks very much, that'd be a really useful feature to have. Thanks
also for making it optional, because probably some installations would
not want it on.
This looks broadly reasonable -- I'm not deeply familiar with
loggerhead -- but I am very curious why you apparently reimplemented
the export-to-tarball feature. I'd rather reuse the bzr code and if
necessary change it to let it be reused here.
When you say "not tested" do you mean you haven't even run it, or only
that you didn't add automatic tests?